[
https://issues.apache.org/jira/browse/HIVE-10799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639118#comment-14639118
]
Prasanth Jayachandran commented on HIVE-10799:
----------------------------------------------
Couple of things:
1) The predicate types doesn't seem to support BINARY types. I am fine with
adding that to a follow up jira as it was never supported before.
2) Can you add a test case for predicate type not matching the literal object
type? The predicate evaluation for such cases should return maybe. I don't see
a test case for it.
Other than that the patch looks good to me.
> Refactor the SearchArgumentFactory to remove the dependence on
> ExprNodeGenericFuncDesc
> --------------------------------------------------------------------------------------
>
> Key: HIVE-10799
> URL: https://issues.apache.org/jira/browse/HIVE-10799
> Project: Hive
> Issue Type: Sub-task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-10799.patch, HIVE-10799.patch, HIVE-10799.patch,
> HIVE-10799.patch, HIVE-10799.patch
>
>
> SearchArgumentFactory and SearchArgumentImpl are high level and shouldn't
> depend on the internals of Hive's AST model.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
