[
https://issues.apache.org/jira/browse/HIVE-20919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688924#comment-16688924
]
Hive QA commented on HIVE-20919:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12948409/HIVE-20919.05.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 15538 tests
executed
*Failed tests:*
{noformat}
TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=196)
[druidmini_dynamic_partition.q,druidmini_test1.q,druidkafkamini_basic.q,druidmini_test_insert.q,druidkafkamini_delimited.q]
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=258)
org.apache.hive.jdbc.TestSSL.testSSLConnectionWithProperty (batchId=258)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/14955/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14955/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14955/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12948409 - PreCommit-HIVE-Build
> Break up UpdateDeleteSemanticAnalyzer
> -------------------------------------
>
> Key: HIVE-20919
> URL: https://issues.apache.org/jira/browse/HIVE-20919
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Affects Versions: 3.2.0
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Fix For: 3.2.0
>
> Attachments: HIVE-20919.01.patch, HIVE-20919.02.patch,
> HIVE-20919.03.patch, HIVE-20919.04.patch, HIVE-20919.05.patch
>
>
> UpdateDeleteSemanticAnalyzer handles update, delete, acid export and merge
> queries by rewriting them to a different form. This is a clear violation of
> [SRP|https://en.wikipedia.org/wiki/Single_responsibility_principle], and
> therefore needs to be refactored. An abstract ancestor needs to take the
> common part, and each of the specific tasks should be handled by a separate
> class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
