[
https://issues.apache.org/jira/browse/HIVE-20797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704972#comment-16704972
]
BELUGA BEHR commented on HIVE-20797:
------------------------------------
[~pvary] Thank you for the review.
I don't like that option. Adding branching logic into logging messages is
dangerous because then we should be writing unit tests to ensure that the
logging message doesn't cause any issues (NPE or otherwise). Using
{{MoreObjects}} is safer because that code is already unit tested and it's
easier to code review for correctness.
> Print Number of Locks Acquired
> ------------------------------
>
> Key: HIVE-20797
> URL: https://issues.apache.org/jira/browse/HIVE-20797
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2, Locking
> Affects Versions: 4.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Labels: newbie, noob
> Attachments: HIVE-20797.1.patch
>
>
> The number of locks acquired by a query can greatly influence the performance
> and stability of the system, especially for ZK locks. Please add INFO level
> logging with the number of locks each query obtains.
> Log here:
> https://github.com/apache/hive/blob/3963c729fabf90009cb67d277d40fe5913936358/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L1670-L1672
> {quote}
> A list of acquired locks will be stored in the
> org.apache.hadoop.hive.ql.Context object and can be retrieved via
> org.apache.hadoop.hive.ql.Context#getHiveLocks.
> {quote}
> https://github.com/apache/hive/blob/758ff449099065a84c46d63f9418201c8a6731b1/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManager.java#L115-L127
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
