[ 
https://issues.apache.org/jira/browse/HIVE-11366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643161#comment-14643161
 ] 

Mostafa Mokhtar commented on HIVE-11366:
----------------------------------------

[~gopalv]
Still problematic. 

{code}
Stack Trace     Sample Count    Percentage(%)
java.util.AbstractList.hashCode()       4,646   24.014
   org.apache.commons.lang.builder.HashCodeBuilder.append(Object)       4,646   
24.014
      org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode() 4,646   
24.014
         java.util.AbstractList.hashCode()      4,646   24.014
            org.apache.commons.lang.builder.HashCodeBuilder.append(Object)      
4,646   24.014
               
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()        4,646  
 24.014
                  java.util.AbstractList.hashCode()     4,646   24.014
                     
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)     4,646   
24.014
                        
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()       4,646   
24.014
                           java.util.AbstractList.hashCode()    4,646   24.014
                              
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)    4,646   24.014
                                 
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()      4,646   
24.014
                                    java.util.AbstractList.hashCode()   4,646   
24.014
                                       
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)   4,646   24.014
                                          
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()     4,646   
24.014
                                             java.util.AbstractList.hashCode()  
4,646   24.014
                                                
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)  4,646   24.014
                                                   
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()    4,646   
24.014
                                                      
java.util.AbstractList.hashCode() 4,646   24.014
                                                         
org.apache.commons.lang.builder.HashCodeBuilder.append(Object) 4,646   24.014
                                                            
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()   4,646   
24.014
                                                               
java.util.AbstractList.hashCode()        4,646   24.014
                                                                  
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)        4,646   
24.014
                                                                     
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()  4,646   
24.014
                                                                        
java.util.AbstractList.hashCode()       4,646   24.014
                                                                           
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)       4,646   
24.014
                                                                              
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode() 4,646   24.014
                                                                                
 java.util.AbstractList.hashCode()      4,645   24.009
                                                                                
    org.apache.commons.lang.builder.HashCodeBuilder.append(Object)      4,645   
24.009
                                                                                
       org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()        
4,645   24.009
                                                                                
          java.util.AbstractList.hashCode()     4,645   24.009
                                                                                
             org.apache.commons.lang.builder.HashCodeBuilder.append(Object)     
4,645   24.009
                                                                                
                
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()       4,645   
24.009
                                                                                
                   java.util.AbstractList.hashCode()    4,645   24.009
                                                                                
                      
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)    4,645   24.009
                                                                                
                         
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()      4,645   
24.009
                                                                                
                            java.util.AbstractList.hashCode()   4,644   24.004
                                                                                
                               
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)   4,644   24.004
                                                                                
                                  
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()     4,644   
24.004
                                                                                
                                     java.util.AbstractList.hashCode()  4,642   
23.993
                                                                                
                                        
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)  4,642   23.993
                                                                                
                                           
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()    4,642   
23.993
                                                                                
                                              java.util.AbstractList.hashCode() 
4,641   23.988
                                                                                
                                                 
org.apache.commons.lang.builder.HashCodeBuilder.append(Object) 4,641   23.988
                                                                                
                                                    
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()   4,641   
23.988
                                                                                
                                                       
java.util.AbstractList.hashCode()        4,641   23.988
                                                                                
                                                          
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)        4,641   
23.988
                                                                                
                                                             
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()  4,641   
23.988
                                                                                
                                                                
java.util.AbstractList.hashCode()       4,641   23.988
                                                                                
                                                                   
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)       4,641   
23.988
                                                                                
                                                                      
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode() 4,641   23.988
                                                                                
                                                                         
java.util.AbstractList.hashCode()      4,641   23.988
                                                                                
                                                                            
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)      4,641   
23.988
                                                                                
                                                                               
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()        4,641  
 23.988
                                                                                
                                                                                
  java.util.AbstractList.hashCode()     4,641   23.988
                                                                                
                                                                                
     org.apache.commons.lang.builder.HashCodeBuilder.append(Object)     4,641   
23.988
                                                                                
                                                                                
        org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()       
4,641   23.988
                                                                                
                                                                                
           java.util.AbstractList.hashCode()    4,641   23.988
                                                                                
                                                                                
              org.apache.commons.lang.builder.HashCodeBuilder.append(Object)    
4,641   23.988
                                                                                
                                                                                
                 
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()      4,641   
23.988
                                                                                
                                                                                
                    java.util.AbstractList.hashCode()   4,641   23.988
                                                                                
                                                                                
                       
org.apache.commons.lang.builder.HashCodeBuilder.append(Object)   4,641   23.988
                                                                                
                                                                                
                          
org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc.hashCode()     4,641   
23.988
                                                                                
                                                                                
                             java.util.AbstractList.hashCode()  4,641   23.988
                                                                                
                                              
org.apache.hadoop.hive.ql.plan.ExprNodeDesc$ExprNodeDescEqualityWrapper.<init>(ExprNodeDesc)
      1       0.005
                                                                                
                                                 
org.apache.hadoop.hive.ql.exec.ExprNodeEvaluatorFactory$EvaluatorContext.getEvaluated(ExprNodeEvaluator)
       1       0.005
                                                                                
                                                    
org.apache.hadoop.hive.ql.exec.ExprNodeEvaluatorFactory.iterate(ExprNodeEvaluator,
 ExprNodeEvaluatorFactory$EvaluatorContext)       1       0.005
                                                                                
                                                       
org.apache.hadoop.hive.ql.exec.ExprNodeEvaluatorFactory.iterate(ExprNodeEvaluator,
 ExprNodeEvaluatorFactory$EvaluatorContext)    1       0.005
                                                                                
                                                          
org.apache.hadoop.hive.ql.exec.ExprNodeEvaluatorFactory.iterate(ExprNodeEvaluator,
 ExprNodeEvaluatorFactory$EvaluatorContext) 1       0.005
{code}

> Avoid right leaning tree hashCode depth during ExprNodeDescEqualityWrapper 
> HashMaps
> -----------------------------------------------------------------------------------
>
>                 Key: HIVE-11366
>                 URL: https://issues.apache.org/jira/browse/HIVE-11366
>             Project: Hive
>          Issue Type: Improvement
>          Components: Logical Optimizer
>    Affects Versions: 1.0.0, 1.2.0, 1.1.0, 1.1.1
>            Reporter: Gopal V
>            Assignee: Gopal V
>         Attachments: HIVE-11366.1.patch
>
>
> For a large sequence of AND clauses, the precedence order results in a deep 
> unbalanced tree.
> (AND A (AND B (AND C (AND D (AND E)....)
> which could result in a hashcode for the top-level expression traversing deep.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to