[
https://issues.apache.org/jira/browse/HIVE-20942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711961#comment-16711961
]
Eugene Koifman edited comment on HIVE-20942 at 12/6/18 8:00 PM:
----------------------------------------------------------------
[~ikryvenko], I agree that you should keep the original call to {{cancel}} but
I think the new one you added is in the wrong {{try-catch}} - shouldn't it be
in the {{finally}} of the {{try-catch}} that contains the {{start}} call?
Also, I think {{LOG.info("Heartbeating comp}}... should be {{debug}} level
was (Author: ekoifman):
[~ikryvenko], I agree that you should keep the original call to {{cancel}} but
I think the new one you added is in the wrong {{try-catch}} - shouldn't it be
in the {{finally}} of the {{try-catch}} that contains the {{start}} call?
Also, I think {{LOG.info("Heartbeating comp}}... should be debug
> Worker should heartbeat its own txn
> -----------------------------------
>
> Key: HIVE-20942
> URL: https://issues.apache.org/jira/browse/HIVE-20942
> Project: Hive
> Issue Type: Bug
> Components: Transactions
> Affects Versions: 4.0.0
> Reporter: Eugene Koifman
> Assignee: Igor Kryvenko
> Priority: Major
> Attachments: HIVE-20942.01.patch, HIVE-20942.02.patch
>
>
> Since HIVE-20823 \{{Worker.java}} starts a txn - should either add a
> heartbeat thread to it or use HiveTxnManager to start txn which will set up
> heartbeat automatically. In the later case make sure it's properly cancelled
> on failures.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
