[
https://issues.apache.org/jira/browse/HIVE-20859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726065#comment-16726065
]
Hive QA commented on HIVE-20859:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12952553/HIVE-20859.01.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 15737 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/15405/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15405/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15405/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12952553 - PreCommit-HIVE-Build
> clean up invocation of Worker/Cleaner/Initiator in test code
> ------------------------------------------------------------
>
> Key: HIVE-20859
> URL: https://issues.apache.org/jira/browse/HIVE-20859
> Project: Hive
> Issue Type: Improvement
> Components: Test, Transactions
> Affects Versions: 3.0.0
> Reporter: Eugene Koifman
> Assignee: Igor Kryvenko
> Priority: Minor
> Attachments: HIVE-20859.01.patch
>
>
> there are many places like {{CompactorTest}} that use
> {code:java|title=CompactorTest.java}
> AtomicBoolean stop = new AtomicBoolean(true);
> Worker t = new Worker();
> t.setThreadId((int) t.getId());
> t.setConf(hiveConf);
> AtomicBoolean looped = new AtomicBoolean();
> t.init(stop, looped);
> t.run();
> {code}
> should instead standardize on {{TestTxnCommands2.runWorker()}}
> same for {{Cleaner}} and {{Initiator}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
