[ 
https://issues.apache.org/jira/browse/HIVE-20758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749824#comment-16749824
 ] 

Barnabas Maidics commented on HIVE-20758:
-----------------------------------------

Hi [~gopalv] ,

I created a solution for this. My patch does not add new functionality to 
Metastore as [~vgarg] suggested but solves the problem.

The only limitation which I couldn't solve is that I think we don't store 
additional keywords in Metastore, which belongs to a constraint (like DISABLE 
or RELY), so I couldn't add it to the result. Do you think these should be 
added to Metastore, or for now it's okay without them as well?

Otherwise, show create table now showing all the constraints (without 
additional keywords) mentioned in the Jira in the following format:

!Screen Shot 2019-01-23 at 11.52.04.png!

 

> Constraints: Show create table does not show constraints
> --------------------------------------------------------
>
>                 Key: HIVE-20758
>                 URL: https://issues.apache.org/jira/browse/HIVE-20758
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 4.0.0
>            Reporter: Gopal V
>            Assignee: Barnabas Maidics
>            Priority: Major
>         Attachments: HIVE-20758.1.patch, Screen Shot 2019-01-23 at 
> 11.52.04.png
>
>
> Even though the desc formatted shows the constraints, the show create table 
> does not
> {code}
> | # Primary Key                                      | NULL                   
>                             | NULL                                            
>    |
> | Table:                                             | 
> tpcds_bin_partitioned_orc_10000.inventory          | NULL                     
>                           |
> | Constraint Name:                                   | pk_in                  
>                             | NULL                                            
>    |
> | Column Names:                                      | inv_date_sk            
>                             | inv_item_sk                                     
>    |
> |                                                    | NULL                   
>                             | NULL                                            
>    |
> | # Foreign Keys                                     | NULL                   
>                             | NULL                                            
>    |
> | Table:                                             | 
> tpcds_bin_partitioned_orc_10000.inventory          | NULL                     
>                           |
> | Constraint Name:                                   | inv_d                  
>                             | NULL                                            
>    |
> | Parent Column Name:tpcds_bin_partitioned_orc_10000.date_dim.d_date_sk | 
> Column Name:inv_date_sk                            | Key Sequence:1           
>                           |
> |                                                    | NULL                   
>                             | NULL                                            
>    |
> | Constraint Name:                                   | inv_i                  
>                             | NULL                                            
>    |
> | Parent Column Name:tpcds_bin_partitioned_orc_10000.item.i_item_sk | Column 
> Name:inv_item_sk                            | Key Sequence:1                  
>                    |
> |                                                    | NULL                   
>                             | NULL                                            
>    |
> | Constraint Name:                                   | inv_w                  
>                             | NULL                                            
>    |
> | Parent Column Name:tpcds_bin_partitioned_orc_10000.warehouse.w_warehouse_sk 
> | Column Name:inv_warehouse_sk                       | Key Sequence:1         
>                             |
> |                                                    | NULL                   
>                             | NULL                                            
>    |
> {code}
> But 
> {code}
> +----------------------------------------------------+
> |                   createtab_stmt                   |
> +----------------------------------------------------+
> | CREATE TABLE `inventory`(                          |
> |   `inv_item_sk` bigint,                            |
> |   `inv_warehouse_sk` bigint,                       |
> |   `inv_quantity_on_hand` int,                      |
> |   `inv_date_sk` bigint)                            |
> | ROW FORMAT SERDE                                   |
> |   'org.apache.hadoop.hive.ql.io.orc.OrcSerde'      |
> | STORED AS INPUTFORMAT                              |
> |   'org.apache.hadoop.hive.ql.io.orc.OrcInputFormat'  |
> | OUTPUTFORMAT                                       |
> |   'org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat' |
> | LOCATION                                           |
> |   
> 'hdfs:///warehouse/tablespace/managed/hive/tpcds_bin_partitioned_orc_10000.db/inventory'
>  |
> | TBLPROPERTIES (                                    |
> |   'bucketing_version'='2',                         |
> |   'transactional'='true',                          |
> |   'transactional_properties'='default',            |
> |   'transient_lastDdlTime'='1539710410')            |
> +----------------------------------------------------+
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to