[ 
https://issues.apache.org/jira/browse/HIVE-20776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751251#comment-16751251
 ] 

Hive QA commented on HIVE-20776:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12956157/HIVE-20776.015_a.branch-3.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/15778/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15778/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15778/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2019-01-24 15:47:12.279
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-15778/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2019-01-24 15:47:12.282
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at a7e704c HIVE-21148: Remove Use StandardCharsets Where Possible 
(BELUGA BEHR via Slim Bouguerra)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at a7e704c HIVE-21148: Remove Use StandardCharsets Where Possible 
(BELUGA BEHR via Slim Bouguerra)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2019-01-24 15:47:12.969
+ rm -rf ../yetus_PreCommit-HIVE-Build-15778
+ mkdir ../yetus_PreCommit-HIVE-Build-15778
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-15778
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-15778/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
error: 
a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
 does not exist in index
error: 
a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
 does not exist in index
error: 
a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
 does not exist in index
error: 
a/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java:
 does not exist in index
error: 
a/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java:
 does not exist in index
error: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
 does not exist in index
error: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
 does not exist in index
error: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
 does not exist in index
error: 
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java:
 does not exist in index
error: 
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java:
 does not exist in index
error: src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: does 
not exist in index
error: src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java: 
does not exist in index
error: src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java: 
does not exist in index
error: src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java: 
does not exist in index
error: 
src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java: 
does not exist in index
The patch does not appear to apply with p0, p1, or p2
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-15778
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12956157 - PreCommit-HIVE-Build

> Run HMS filterHooks on server-side in addition to client-side
> -------------------------------------------------------------
>
>                 Key: HIVE-20776
>                 URL: https://issues.apache.org/jira/browse/HIVE-20776
>             Project: Hive
>          Issue Type: Improvement
>          Components: Standalone Metastore
>            Reporter: Karthik Manamcheri
>            Assignee: Na Li
>            Priority: Major
>         Attachments: HIVE-20776.001.patch, HIVE-20776.003.patch, 
> HIVE-20776.004.patch, HIVE-20776.005.patch, HIVE-20776.006.patch, 
> HIVE-20776.007.patch, HIVE-20776.007.patch, HIVE-20776.008.patch, 
> HIVE-20776.009.patch, HIVE-20776.009.patch, HIVE-20776.010.patch, 
> HIVE-20776.011.patch, HIVE-20776.011.patch, HIVE-20776.012.patch, 
> HIVE-20776.013.patch, HIVE-20776.014.patch, HIVE-20776.015.branch-3.patch, 
> HIVE-20776.015.patch, HIVE-20776.015_a.branch-3.patch
>
>
> In HMS, I noticed that all the filter hooks are applied on the client side 
> (in HiveMetaStoreClient.java). Is there any reason why we can't apply the 
> filters on the server-side?
> Motivation: Some newer apache projects such as Kudu use HMS for metadata 
> storage. Kudu is not completely Java-based and there are interaction points 
> where they have C++ clients. In such cases, it would be ideal to have 
> consistent behavior from HMS side as far as filters, etc are concerned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to