[ 
https://issues.apache.org/jira/browse/HIVE-21083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751814#comment-16751814
 ] 

Hive QA commented on HIVE-21083:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12956215/HIVE-21083.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15708 tests 
executed
*Failed tests:*
{noformat}
org.apache.hive.jdbc.TestSSL.testMetastoreWithSSL (batchId=260)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/15787/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15787/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15787/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12956215 - PreCommit-HIVE-Build

> Remove the requirement to specify the truststore location when TLS to the 
> database is turned on
> -----------------------------------------------------------------------------------------------
>
>                 Key: HIVE-21083
>                 URL: https://issues.apache.org/jira/browse/HIVE-21083
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore, Standalone Metastore
>    Affects Versions: 4.0.0
>            Reporter: Morio Ramdenbourg
>            Assignee: Morio Ramdenbourg
>            Priority: Major
>         Attachments: HIVE-21083.2.patch, HIVE-21083.patch
>
>
> In the current implementation, 
> [ObjectStore.configureSSL|https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L349-L382]
>  throws an exception if TLS to the database is turned on 
> (_metastore.dbaccess.ssl.use.SSL_) but a truststore file location 
> (_metastore.dbaccess.ssl.truststore.path_) is not specified.
> However, according to the [JSSE (Java 8) 
> documentation|https://docs.oracle.com/javase/8/docs/technotes/guides/security/jsse/JSSERefGuide.html#InstallationAndCustomization],
>  the Java truststore file location system property 
> (_javax.net.ssl.trustStore_) defaults to using the "_jssecacerts_, if it 
> exists. Otherwise, _cacerts_" files. These are the default truststores that 
> come with the Java installation and contain a list of well-known certificate 
> authorities.
> It was identified that one valid way of configuring TLS is by adding to these 
> default files. In that case, no changes to the truststore properties are 
> necessary. We should support this case by changing the following logic to 
> remove the requirement for the truststore file location config property:
> {code:java}
> String trustStorePath = MetastoreConf.getVar(conf, 
>         ConfVars.DBACCESS_SSL_TRUSTSTORE_PATH).trim();
> if (trustStorePath.isEmpty()) {
>         throw new IllegalArgumentException("SSL to the database store has 
> been enabled but " + 
>         ConfVars.DBACCESS_SSL_TRUSTSTORE_PATH.toString() + " is empty. "
>         + "Set this property to enable SSL.");
> }
> {code}
> We should also loosen the requirement on the truststore password if the user 
> decides to use the Java defaults



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to