[
https://issues.apache.org/jira/browse/HIVE-20699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754507#comment-16754507
]
Eugene Koifman commented on HIVE-20699:
---------------------------------------
I left a few of minor comments on RB for patch 9. Overall LGTM, except for
{{HIVE_TRANSACTIONAL_TABLE_SCAN}} not being visible in {{HiveSplitGenerator}}.
While not caused by this patch I don't think it can properly work in production
w/o it being fixed.
> Query based compactor for full CRUD Acid tables
> -----------------------------------------------
>
> Key: HIVE-20699
> URL: https://issues.apache.org/jira/browse/HIVE-20699
> Project: Hive
> Issue Type: New Feature
> Components: Transactions
> Affects Versions: 3.1.0
> Reporter: Eugene Koifman
> Assignee: Vaibhav Gumashta
> Priority: Major
> Attachments: HIVE-20699.1.patch, HIVE-20699.1.patch,
> HIVE-20699.2.patch, HIVE-20699.3.patch, HIVE-20699.4.patch,
> HIVE-20699.5.patch, HIVE-20699.6.patch, HIVE-20699.7.patch,
> HIVE-20699.8.patch, HIVE-20699.9.patch
>
>
> Currently the Acid compactor is implemented as generated MR job
> ({{CompactorMR.java}}).
> It could also be expressed as a Hive query that reads from a given partition
> and writes data back to the same partition. This will merge the deltas and
> 'apply' the delete events. The simplest would be to just use Insert
> Overwrite but that will change all ROW__IDs which we don't want.
> Need to implement this in a way that preserves ROW__IDs and creates a new
> {{base_x}} directory to handle Major compaction.
> Minor compaction will be investigated separately.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
