[
https://issues.apache.org/jira/browse/HIVE-20849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760912#comment-16760912
]
Naveen Gangam commented on HIVE-20849:
--------------------------------------
[~belugabehr] Thanks for cleaning up some of these logging messages. I see that
the proposed fix unwraps the logging code from {{isXEnabled}} checks. Pardon my
ignorance with the recent changes. Are these checks no longer considered an
optimization to prevent the [potentially unnecessary] computation in generating
log strings (concatenation, etc)?
I realize in this case, its all string concatenation (without any expensive
method calls or exception stacks etc) but still there is some memory overhead
in concatenating strings. I dont have performance numbers either way but given
that these are mostly DEBUG logging that we unwrapped, that is normally turned
off on all production clusters, could the unnecessary overhead (memory and
performance) be more than we anticipate? This class is a well used codepath.
Even if some implementations of Loggers have a builtin checks in
{{LOG.debug()}} methods that make these additional checks unnecessary, there
are probably other implementations that dont.
Was just thinking out loud. Thanks
> Review of ConstantPropagateProcFactory
> --------------------------------------
>
> Key: HIVE-20849
> URL: https://issues.apache.org/jira/browse/HIVE-20849
> Project: Hive
> Issue Type: Improvement
> Components: Logical Optimizer
> Affects Versions: 3.1.0, 4.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HIVE-20849.1.patch, HIVE-20849.1.patch,
> HIVE-20849.2.patch, HIVE-20849.3.patch, HIVE-20849.4.patch,
> HIVE-20849.5.patch, HIVE-20849.6.patch
>
>
> I was looking at this class because it blasts a lot of useless (to an admin)
> information to the logs. Especially if the table has a lot of columns, I see
> big blocks of logging that are meaningless to me. I request that the logging
> is toned down to debug, and some other improvements to the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
