[
https://issues.apache.org/jira/browse/HIVE-20849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760819#comment-16760819
]
BELUGA BEHR edited comment on HIVE-20849 at 2/6/19 2:27 PM:
------------------------------------------------------------
[~pvary] Thanks for the review!
# Do you mean why did I not use parameters in the logging? First, I wanted to
change as little as possible. I know you prefer that. :) Second, using
parameters is the fastest way to *not* log [1], but it would be very unlikely
that someone would configure their logging to be CRITICAL level only, so in
practice, these messages will always be logged; there is no need to optimize.
# The {{Collections.emptyMap()}} is relying on unit tests and qtests for
verification.
[1] https://www.slf4j.org/faq.html#logging_performance
was (Author: belugabehr):
[~pvary] Thanks for the review!
# Do you mean why did I not use parameters in the logging? First, I wanted to
change as little as possible. I know you prefer that. :) Second, using
parameters is the fastest way to *not* log [1], but it would be very unlikely
that someone would configure their logging to be CRITICAL level only, so in
practice, these messages will always be logged; there is no need to optimize.
# The {{Collections.emptyMap()}} is relying on unit tests for verification.
[1] https://www.slf4j.org/faq.html#logging_performance
> Review of ConstantPropagateProcFactory
> --------------------------------------
>
> Key: HIVE-20849
> URL: https://issues.apache.org/jira/browse/HIVE-20849
> Project: Hive
> Issue Type: Improvement
> Components: Logical Optimizer
> Affects Versions: 3.1.0, 4.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HIVE-20849.1.patch, HIVE-20849.1.patch,
> HIVE-20849.2.patch, HIVE-20849.3.patch, HIVE-20849.4.patch,
> HIVE-20849.5.patch, HIVE-20849.6.patch
>
>
> I was looking at this class because it blasts a lot of useless (to an admin)
> information to the logs. Especially if the table has a lot of columns, I see
> big blocks of logging that are meaningless to me. I request that the logging
> is toned down to debug, and some other improvements to the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
