[
https://issues.apache.org/jira/browse/HIVE-19430?focusedWorklogId=199189&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-199189
]
ASF GitHub Bot logged work on HIVE-19430:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/19 12:12
Start Date: 15/Feb/19 12:12
Worklog Time Spent: 10m
Work Description: ashutosh-bapat commented on pull request #537:
HIVE-19430 : ObjectStore.cleanNotificationEvents OutOfMemory on large number of
pending events
URL: https://github.com/apache/hive/pull/537#discussion_r257211237
##########
File path:
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
##########
@@ -1142,10 +1142,8 @@ public void run() {
} catch (Exception ex) {
//catching exceptions here makes sure that the thread doesn't die in
case of unexpected
//exceptions
- LOG.warn(
- "Exception received while cleaning notifications. More details
can be found in debug mode"
- + ex.getMessage());
- LOG.debug(ex.getMessage(), ex);
Review comment:
There is no point in dropping a warning with just the exception message and
asking user to turn on debug level to investigate further. An exception has
happened and if we are giving out "warn"ing better we also log the exception
accompanying it instead of a separate debug message. WARN has higher priority
than debug.
It will make the logs slightly verbose but will be more useful in production
environment where changing log level isn't that easy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 199189)
Time Spent: 50m (was: 40m)
> ObjectStore.cleanNotificationEvents OutOfMemory on large number of pending
> events
> ---------------------------------------------------------------------------------
>
> Key: HIVE-19430
> URL: https://issues.apache.org/jira/browse/HIVE-19430
> Project: Hive
> Issue Type: Bug
> Reporter: Thejas M Nair
> Assignee: Ashutosh Bapat
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-19430.01.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> If there are large number of events that haven't been cleaned up for some
> reason, then ObjectStore.cleanNotificationEvents() can run out of memory
> while it loads all the events to be deleted.
> It should fetch events in batches.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
