[
https://issues.apache.org/jira/browse/HIVE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769595#comment-16769595
]
Vihang Karajgaonkar commented on HIVE-19430:
--------------------------------------------
Thanks for providing the patch. Looks good to me. One suggestion related to the
log message.
"LOG.warn("Exception received while cleaning notifications. More details can be
found in debug mode", ex);"
The log message above is not super helpful, since it is not necessary that
logging level is in debug mode when the exception occurred. Since you already
are adding the exception trace in the warning, may be you can remove the "More
details can be found ..." statement.
> ObjectStore.cleanNotificationEvents OutOfMemory on large number of pending
> events
> ---------------------------------------------------------------------------------
>
> Key: HIVE-19430
> URL: https://issues.apache.org/jira/browse/HIVE-19430
> Project: Hive
> Issue Type: Bug
> Reporter: Thejas M Nair
> Assignee: Ashutosh Bapat
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-19430.01.patch, HIVE-19430.02.patch,
> HIVE-19430.03.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> If there are large number of events that haven't been cleaned up for some
> reason, then ObjectStore.cleanNotificationEvents() can run out of memory
> while it loads all the events to be deleted.
> It should fetch events in batches.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
