[
https://issues.apache.org/jira/browse/HIVE-21292?focusedWorklogId=202694&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-202694
]
ASF GitHub Bot logged work on HIVE-21292:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/19 15:37
Start Date: 22/Feb/19 15:37
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #543:
HIVE-21292: Break up DDLTask 1 - extract Database related operations
URL: https://github.com/apache/hive/pull/543#discussion_r259392471
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/ddl/database/AlterDatabaseDesc.java
##########
@@ -16,112 +16,100 @@
* limitations under the License.
*/
-package org.apache.hadoop.hive.ql.plan;
+package org.apache.hadoop.hive.ql.exec.ddl.database;
import java.io.Serializable;
import java.util.Map;
+import org.apache.hadoop.hive.ql.exec.ddl.DDLDesc;
+import org.apache.hadoop.hive.ql.exec.ddl.DDLTask2;
import org.apache.hadoop.hive.ql.parse.ReplicationSpec;
+import org.apache.hadoop.hive.ql.plan.Explain;
import org.apache.hadoop.hive.ql.plan.Explain.Level;
+import org.apache.hadoop.hive.ql.plan.PrincipalDesc;
/**
- * AlterDatabaseDesc.
- *
+ * DDL task description for ALTER DATABASE commands.
*/
@Explain(displayName = "Alter Database", explainLevels = { Level.USER,
Level.DEFAULT, Level.EXTENDED })
public class AlterDatabaseDesc extends DDLDesc implements Serializable {
-
private static final long serialVersionUID = 1L;
- // Only altering the database property and owner is currently supported
- public static enum ALTER_DB_TYPES {
- ALTER_PROPERTY, ALTER_OWNER, ALTER_LOCATION
- };
-
- ALTER_DB_TYPES alterType;
- String databaseName;
- Map<String, String> dbProperties;
- PrincipalDesc ownerPrincipal;
- ReplicationSpec replicationSpec;
- String location;
+ static {
+ DDLTask2.registerOperator(AlterDatabaseDesc.class,
AlterDatabaseOperation.class);
+ }
/**
- * For serialization only.
+ * Supported type of alter db commands.
+ * Only altering the database property and owner is currently supported
*/
- public AlterDatabaseDesc() {
- }
+ public enum AlterDbType {
+ ALTER_PROPERTY, ALTER_OWNER, ALTER_LOCATION
+ };
- public AlterDatabaseDesc(String databaseName, Map<String, String> dbProps,
Review comment:
Basically AlterDatabaseOperation (or in more general every XXXOperation
could be a task as well, and every XXXDesc could have their own XXXWork class.
But that would mean a lot of repetitive code, so having a common Task, and Work
class for them is just reusing the same boilerplate code. Having a separate SA
is a good idea, I think when DDLTask is cut to pieces the next step should be a
to cut DDLSemanticAnalyzer too!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 202694)
Time Spent: 6h 50m (was: 6h 40m)
> Break up DDLTask 1 - extract Database related operations
> --------------------------------------------------------
>
> Key: HIVE-21292
> URL: https://issues.apache.org/jira/browse/HIVE-21292
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Affects Versions: 3.1.1
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21292.01.patch, HIVE-21292.02.patch,
> HIVE-21292.03.patch, HIVE-21292.04.patch, HIVE-21292.05.patch,
> HIVE-21292.06.patch
>
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> DDLTask is a huge class, more than 5000 lines long. The related DDLWork is
> also a huge class, which has a field for each DDL operation it supports. The
> goal is to refactor these in order to have everything cut into more
> handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each operation
> * have a package for each operation group (database ddl, table ddl, etc), so
> the amount of classes under a package is more manageable
> * make all the requests (DDLDesc subclasses) immutable
> * DDLTask should be agnostic to the actual operations
> * right now let's ignore the issue of having some operations handled by
> DDLTask which are not actual DDL operations (lock, unlock, desc...)
> In the interim time when there are two DDLTask and DDLWork classes in the
> code base the new ones in the new package are called DDLTask2 and DDLWork2
> thus avoiding the usage of fully qualified class names where both the old and
> the new classes are in use.
> Step #1: extract all the database related operations from the old DDLTask,
> and move them under the new package. Also create the new internal framework.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
