[
https://issues.apache.org/jira/browse/HIVE-21198?focusedWorklogId=204218&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-204218
]
ASF GitHub Bot logged work on HIVE-21198:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/19 12:11
Start Date: 26/Feb/19 12:11
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #550: HIVE-21198
Introduce a database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r260256192
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/incremental/IncrementalLoadTasksBuilder.java
##########
@@ -266,16 +271,15 @@ private boolean shouldReplayEvent(FileStatus dir,
DumpType dumpType, String dbNa
return updateReplIdTxnTask;
}
- private Task<? extends Serializable> tableUpdateReplStateTask(String dbName,
String tableName,
- Map<String, String>
partSpec, String replState,
- Task<? extends
Serializable> preCursor) throws SemanticException {
+ private Task<? extends Serializable> tableUpdateReplStateTask(TableName
tableName, Map<String, String> partSpec,
Review comment:
now that I see this...I think that it would probably make sense to also
include `partSpec` into this object
(`PartishRef`: `catalog,database,tablename,partitonspec` ) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 204218)
Time Spent: 40m (was: 0.5h)
> Introduce a database object reference class
> -------------------------------------------
>
> Key: HIVE-21198
> URL: https://issues.apache.org/jira/browse/HIVE-21198
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: David Lavati
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21198.1.patch, HIVE-21198.2.patch,
> HIVE-21198.3.patch, HIVE-21198.4.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> There are many places in which "{databasename}.{tablename}" is passed as a
> single string; there are some places where the they travel as 2 separate
> arguments.
> Idea would be to introduce a simple immutable class with 2 fields ; and pass
> these informations together. Making this better is required if we would be
> wanting to enable dot in tablenames
> HIVE-16907, HIVE-21151
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
