[
https://issues.apache.org/jira/browse/HIVE-21286?focusedWorklogId=207599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207599
]
ASF GitHub Bot logged work on HIVE-21286:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/19 04:27
Start Date: 05/Mar/19 04:27
Worklog Time Spent: 10m
Work Description: ashutosh-bapat commented on pull request #551:
HIVE-21286: Hive should support clean-up of previously bootstrapped tables when
retry from different dump.
URL: https://github.com/apache/hive/pull/551#discussion_r262343384
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -279,6 +292,72 @@ a database ( directory )
return 0;
}
+ /**
+ * Cleanup/drop tables from the given database which are bootstrapped by
input dump dir.
+ * @throws HiveException Failed to drop the tables.
+ * @throws IOException File operations failure.
+ * @throws InvalidInputException Invalid input dump directory.
+ */
+ private void bootstrapRollbackTask() throws HiveException, IOException,
InvalidInputException {
+ Path bootstrapDirectory = new PathBuilder(work.bootstrapDumpToRollback)
+ .addDescendant(ReplUtils.INC_BOOTSTRAP_ROOT_DIR_NAME).build();
+ FileSystem fs = bootstrapDirectory.getFileSystem(conf);
+
+ if (!fs.exists(bootstrapDirectory)) {
+ throw new InvalidInputException("Input bootstrap dump directory to
rollback doesn't exist: "
+ + bootstrapDirectory);
+ }
+
+ FileStatus[] fileStatuses = fs.listStatus(bootstrapDirectory,
EximUtil.getDirectoryFilter(fs));
+ if ((fileStatuses == null) || (fileStatuses.length == 0)) {
+ throw new InvalidInputException("Input bootstrap dump directory to
rollback is empty: "
+ + bootstrapDirectory);
+ }
+
+ if (StringUtils.isNotBlank(work.dbNameToLoadIn) && (fileStatuses.length >
1)) {
+ throw new InvalidInputException("Multiple DB dirs in the dump: " +
bootstrapDirectory
+ + " is not allowed to load to single target DB: " +
work.dbNameToLoadIn);
+ }
+
+ for (FileStatus dbDir : fileStatuses) {
+ Path dbLevelPath = dbDir.getPath();
+ String dbNameInDump = dbLevelPath.getName();
+
+ List<String> tableNames = new ArrayList<>();
+ RemoteIterator<LocatedFileStatus> filesIterator =
fs.listFiles(dbLevelPath, true);
+ while (filesIterator.hasNext()) {
+ Path nextFile = filesIterator.next().getPath();
+ String filePath = nextFile.toString();
+ if (filePath.endsWith(EximUtil.METADATA_NAME)) {
+ // Remove dbLevelPath from the current path to check if this
_metadata file is under DB or
+ // table level directory.
+ String replacedString = filePath.replace(dbLevelPath.toString(), "");
+ if (!replacedString.equalsIgnoreCase(EximUtil.METADATA_NAME)) {
+ tableNames.add(nextFile.getParent().getName());
+ }
+ }
+ }
+
+ // No tables listed in the DB level directory to be dropped.
+ if (tableNames.isEmpty()) {
+ LOG.info("No tables are listed to be dropped for Database: {} in
bootstrap dump: {}",
+ dbNameInDump, bootstrapDirectory);
+ continue;
+ }
+
+ // Drop all tables bootstrapped from previous dump.
+ // Get the target DB in which previously bootstrapped tables to be
dropped. If user specified
+ // DB name as input in REPL LOAD command, then use it.
+ String dbName = (StringUtils.isNotBlank(work.dbNameToLoadIn) ?
work.dbNameToLoadIn : dbNameInDump);
+
+ Hive db = getHive();
+ for (String table : tableNames) {
+ db.dropTable(dbName + "." + table, true);
Review comment:
The external table directory will still be left behind. That's the problem I
am trying to highlight here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 207599)
> Hive should support clean-up of previously bootstrapped tables when retry
> from different dump.
> ----------------------------------------------------------------------------------------------
>
> Key: HIVE-21286
> URL: https://issues.apache.org/jira/browse/HIVE-21286
> Project: Hive
> Issue Type: Bug
> Components: repl
> Affects Versions: 4.0.0
> Reporter: Sankar Hariappan
> Assignee: Sankar Hariappan
> Priority: Major
> Labels: DR, Replication, pull-request-available
> Attachments: HIVE-21286.01.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> If external tables are enabled for replication on an existing repl policy,
> then bootstrapping of external tables are combined with incremental dump.
> If incremental bootstrap load fails with non-retryable error for which user
> will have to manually drop all the external tables before trying with another
> bootstrap dump. For full bootstrap, to retry with different dump, we
> suggested user to drop the DB but in this case they need to manually drop all
> the external tables which is not so user friendly. So, need to handle it in
> Hive side as follows.
> REPL LOAD takes additional config (passed by user in WITH clause) that says,
> drop all the tables which are bootstrapped from previous dump.
> hive.repl.rollback.bootstrap.load=<previous_bootstrap_dump_dir>
> Hive will use this config only if the current dump is bootstrap dump or
> combined bootstrap in incremental dump.
> Caution to be taken by user that this config should not be passed if previous
> REPL LOAD (with bootstrap) was successful or any successful incremental
> dump+load happened after "previous_bootstrap_dump_dir".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
