[
https://issues.apache.org/jira/browse/HIVE-21292?focusedWorklogId=210905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-210905
]
ASF GitHub Bot logged work on HIVE-21292:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/19 09:42
Start Date: 11/Mar/19 09:42
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #543:
HIVE-21292: Break up DDLTask 1 - extract Database related operations
URL: https://github.com/apache/hive/pull/543#discussion_r264151355
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/ddl/database/CreateDatabaseOperation.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.exec.ddl.database;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.api.AlreadyExistsException;
+import org.apache.hadoop.hive.metastore.api.Database;
+import org.apache.hadoop.hive.metastore.api.PrincipalType;
+import org.apache.hadoop.hive.ql.ErrorMsg;
+import org.apache.hadoop.hive.ql.exec.Utilities;
+import org.apache.hadoop.hive.ql.exec.ddl.DDLOperation;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.hive.ql.session.SessionState;
+
+/**
+ * Operation process of creating a database.
+ */
+public class CreateDatabaseOperation extends DDLOperation<CreateDatabaseDesc> {
+ private static final String DATABASE_PATH_SUFFIX = ".db";
+
+ @Override
+ public int execute() throws HiveException {
+ Database database = new Database();
+ database.setName(ddlDesc.getName());
+ database.setDescription(ddlDesc.getComment());
+ database.setLocationUri(ddlDesc.getLocationUri());
+ database.setParameters(ddlDesc.getDatabaseProperties());
+ database.setOwnerName(SessionState.getUserFromAuthenticator());
+ database.setOwnerType(PrincipalType.USER);
+
+ try {
+ makeLocationQualified(database);
+ db.createDatabase(database, ddlDesc.getIfNotExists());
+ } catch (AlreadyExistsException ex) {
+ //it would be better if AlreadyExistsException had an errorCode field....
+ throw new HiveException(ex, ErrorMsg.DATABASE_ALREADY_EXISTS,
ddlDesc.getName());
+ }
+
+ return 0;
+ }
+
+ private void makeLocationQualified(Database database) throws HiveException {
Review comment:
I don't see how, the goal of this method is to make the location uri of the
database qualified, so Database needs to be passed to it. Or would you rather
have a method that just returns the new qualified locationUri, and then pass it
to the database?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 210905)
Time Spent: 7h 50m (was: 7h 40m)
> Break up DDLTask - extract Database related operations
> ------------------------------------------------------
>
> Key: HIVE-21292
> URL: https://issues.apache.org/jira/browse/HIVE-21292
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Affects Versions: 3.1.1
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21292.01.patch, HIVE-21292.02.patch,
> HIVE-21292.03.patch, HIVE-21292.04.patch, HIVE-21292.05.patch,
> HIVE-21292.06.patch, HIVE-21292.07.patch, HIVE-21292.08.patch,
> HIVE-21292.09.patch, HIVE-21292.10.patch, HIVE-21292.11.patch,
> HIVE-21292.12.patch, HIVE-21292.13.patch, HIVE-21292.14.patch,
> HIVE-21292.15.patch, HIVE-21292.15.patch, HIVE-21292.16.patch,
> HIVE-21292.17.patch
>
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> DDLTask is a huge class, more than 5000 lines long. The related DDLWork is
> also a huge class, which has a field for each DDL operation it supports. The
> goal is to refactor these in order to have everything cut into more
> handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each operation
> * have a package for each operation group (database ddl, table ddl, etc), so
> the amount of classes under a package is more manageable
> * make all the requests (DDLDesc subclasses) immutable
> * DDLTask should be agnostic to the actual operations
> * right now let's ignore the issue of having some operations handled by
> DDLTask which are not actual DDL operations (lock, unlock, desc...)
> In the interim time when there are two DDLTask and DDLWork classes in the
> code base the new ones in the new package are called DDLTask2 and DDLWork2
> thus avoiding the usage of fully qualified class names where both the old and
> the new classes are in use.
> Step #1: extract all the database related operations from the old DDLTask,
> and move them under the new package. Also create the new internal framework.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
