[ 
https://issues.apache.org/jira/browse/HIVE-21205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797422#comment-16797422
 ] 

Vihang Karajgaonkar commented on HIVE-21205:
--------------------------------------------

Thanks for the patch [~bharos92]. You use {{assertTrue}} or {{assertFalse}} 
instead of {{assertEquals(false,value)}}. Also, do you need to add this check 
in {{sqlInsertTable}} testcase also. The {{sqlInsertPartition}} test does a 
{{insert into table ....}} sql as well. Would be good to verify that the 
replace flag is false in such a case as well.

> Tests for replace flag in insert event messages in Metastore notifications.
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-21205
>                 URL: https://issues.apache.org/jira/browse/HIVE-21205
>             Project: Hive
>          Issue Type: Test
>            Reporter: Bharathkrishna Guruvayoor Murali
>            Assignee: Bharathkrishna Guruvayoor Murali
>            Priority: Minor
>         Attachments: HIVE-21205.1.patch
>
>
> The replace flag is initially added in HIVE-16197. It would be good to have 
> some tests in TestDbNotificationListener to validate if the flag is set as 
> expected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to