[ https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798181#comment-16798181 ]
Ashutosh Chauhan commented on HIVE-20580: ----------------------------------------- [~pvary] I will get rid of isOriginal(Footer). I don't see it being part of a public interface and I would rather not leave a public method which is unused in code. LGTM otherwise. > OrcInputFormat.isOriginal() should not rely on hive.acid.key.index > ------------------------------------------------------------------ > > Key: HIVE-20580 > URL: https://issues.apache.org/jira/browse/HIVE-20580 > Project: Hive > Issue Type: Improvement > Components: Transactions > Affects Versions: 3.1.0 > Reporter: Eugene Koifman > Assignee: Peter Vary > Priority: Major > Attachments: HIVE-20580.2.patch, HIVE-20580.3.patch, > HIVE-20580.4.patch, HIVE-20580.5.patch, HIVE-20580.6.patch, HIVE-20580.patch > > > {{org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.isOriginal()}} is checking > for presence of {{hive.acid.key.index}} in the footer. This is only created > when the file is written by {{OrcRecordUpdater}}. It should instead check > for presence of Acid metadata columns so that a file can be produced by > something other than {{OrcRecordUpater}}. > Also, {{hive.acid.key.index}} counts number of different type of events which > is not really useful for Acid V2 (as of Hive 3) since each file only has 1 > type of event. -- This message was sent by Atlassian JIRA (v7.6.3#76005)