[
https://issues.apache.org/jira/browse/HIVE-21465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798809#comment-16798809
]
Laszlo Bodor commented on HIVE-21465:
-------------------------------------
Could someone take a look at this? 02.patch contains a plan which would be
suitable to eliminate the duplication of the very same logic
I would continue with the rest of the VectorExpression classes, but I need a
review first
https://reviews.apache.org/r/70270/
> Introduce a base abstract VectorExpression to eliminate further code
> duplications
> ---------------------------------------------------------------------------------
>
> Key: HIVE-21465
> URL: https://issues.apache.org/jira/browse/HIVE-21465
> Project: Hive
> Issue Type: Bug
> Reporter: Laszlo Bodor
> Assignee: Laszlo Bodor
> Priority: Major
> Attachments: HIVE-21465.01.patch, HIVE-21465.02.patch
>
>
> In vectorized expressions, from time to time, I see a similar/same logic to
> be repeated, which always consists of some stuff like:
> 1. some inner loops (even the comments are the same)
> {code}
> grep -iRH "Set isNull before call in case it changes it mind" | grep
> "ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/"
> {code}
> 2. call to an actual "business logic" function ==> 1 line which could be
> abstracted... and it has been abstracted in hive codebase in n different
> cases.
> However, an abstract BaseVectorExpression would not force anybody to extend
> it instead of VectorExpression and not copy the code again, but it could be a
> good start and an example.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
