[
https://issues.apache.org/jira/browse/HIVE-21471?focusedWorklogId=217786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-217786
]
ASF GitHub Bot logged work on HIVE-21471:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/19 02:48
Start Date: 25/Mar/19 02:48
Worklog Time Spent: 10m
Work Description: maheshk114 commented on pull request #578: HIVE-21471:
Replicating conversion of managed to external table leaks HDFS files at target.
URL: https://github.com/apache/hive/pull/578#discussion_r268474795
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
##########
@@ -99,9 +100,12 @@ public void alterTable(RawStore msdb, Warehouse wh, String
catName, String dbnam
dbname = dbname.toLowerCase();
final boolean cascade = environmentContext != null
- && environmentContext.isSetProperties()
- && StatsSetupConst.TRUE.equals(environmentContext.getProperties().get(
- StatsSetupConst.CASCADE));
+ && environmentContext.isSetProperties()
+ &&
StatsSetupConst.TRUE.equals(environmentContext.getProperties().get(StatsSetupConst.CASCADE));
+ final boolean replDataLocationChanged = environmentContext != null
Review comment:
yes ..i think the flag sent from hive server to meta store using environment
context is not required ...the code changes are redundant ..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 217786)
Time Spent: 4h 10m (was: 4h)
> Replicating conversion of managed to external table leaks HDFS files at
> target.
> -------------------------------------------------------------------------------
>
> Key: HIVE-21471
> URL: https://issues.apache.org/jira/browse/HIVE-21471
> Project: Hive
> Issue Type: Bug
> Components: repl
> Affects Versions: 4.0.0
> Reporter: Sankar Hariappan
> Assignee: Sankar Hariappan
> Priority: Major
> Labels: DR, pull-request-available, replication
> Attachments: HIVE-21471.01.patch, HIVE-21471.02.patch,
> HIVE-21471.03.patch
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> While replicating the ALTER event to convert managed table to external table,
> the data location for the table is changed under input base directory for
> external tables replication. But, the old location remains there and would be
> leaked for ever.
> ALTER TABLE T1 SET TBLPROPERTIES('EXTERNAL'='true');
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
