[
https://issues.apache.org/jira/browse/HIVE-21537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805611#comment-16805611
]
Hive QA commented on HIVE-21537:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
12s{color} | {color:blue} ql in master has 2256 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
44s{color} | {color:red} ql: The patch generated 1 new + 180 unchanged - 1
fixed = 181 total (was 181) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
33s{color} | {color:red} ql generated 2 new + 2254 unchanged - 2 fixed = 2256
total (was 2256) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 36s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Switch statement found in
org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveSubQueryRemoveRule.apply(RelMetadataQuery,
RexSubQuery, Set, RelOptUtil$Logic, HiveSubQRemoveRelBuilder, int, int,
boolean) where one case falls through to the next case At
HiveSubQueryRemoveRule.java:RexSubQuery, Set, RelOptUtil$Logic,
HiveSubQRemoveRelBuilder, int, int, boolean) where one case falls through to
the next case At HiveSubQueryRemoveRule.java:[lines 426-429] |
| | Switch statement found in
org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveSubQueryRemoveRule.apply(RelMetadataQuery,
RexSubQuery, Set, RelOptUtil$Logic, HiveSubQRemoveRelBuilder, int, int,
boolean) where default case is missing At
HiveSubQueryRemoveRule.java:RexSubQuery, Set, RelOptUtil$Logic,
HiveSubQRemoveRelBuilder, int, int, boolean) where default case is missing At
HiveSubQueryRemoveRule.java:[lines 286-317] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16769/dev-support/hive-personality.sh
|
| git revision | master / 146611b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16769/yetus/diff-checkstyle-ql.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16769/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16769/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Scalar query rewrite could be improved to not generate an extra join if
> subquery is guaranteed to produce atmost one row
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-21537
> URL: https://issues.apache.org/jira/browse/HIVE-21537
> Project: Hive
> Issue Type: Improvement
> Components: Query Planning
> Affects Versions: 4.0.0
> Reporter: Vineet Garg
> Assignee: Vineet Garg
> Priority: Major
> Labels: sub-query
> Attachments: HIVE-21537.1.patch, HIVE-21537.2.patch,
> HIVE-21537.3.patch
>
>
> Currently Hive planner introduces this branch and later executes a rule to
> remove this branch if it could.
> Subquery remove rule itself could check if subquery will produce max one row
> (using relmetadat's getMaxRowCount) and avoid introducing this branch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
