[
https://issues.apache.org/jira/browse/HIVE-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816035#comment-16816035
]
Hive QA commented on HIVE-14669:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
46s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
26s{color} | {color:blue} cli in master has 13 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
48s{color} | {color:blue} itests/util in master has 46 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} cli: The patch generated 0 new + 41 unchanged - 2
fixed = 41 total (was 43) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} The patch util passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
37s{color} | {color:red} cli generated 6 new + 7 unchanged - 6 fixed = 13 total
(was 13) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
55s{color} | {color:red} itests/util generated 2 new + 45 unchanged - 1 fixed =
47 total (was 46) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 15s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:cli |
| | Dead store to response in
org.apache.hadoop.hive.cli.CliDriver.processFile(String) At
CliDriver.java:org.apache.hadoop.hive.cli.CliDriver.processFile(String) At
CliDriver.java:[line 501] |
| | Dead store to ret in
org.apache.hadoop.hive.cli.CliDriver.processLine(String, boolean) At
CliDriver.java:org.apache.hadoop.hive.cli.CliDriver.processLine(String,
boolean) At CliDriver.java:[line 390] |
| | Found reliance on default encoding in
org.apache.hadoop.hive.cli.CliDriver.processFile(String):in
org.apache.hadoop.hive.cli.CliDriver.processFile(String): new
java.io.InputStreamReader(InputStream) At CliDriver.java:[line 503] |
| | org.apache.hadoop.hive.cli.CliDriver.processCmd(String) invokes
System.exit(...), which shuts down the entire virtual machine At
CliDriver.java:down the entire virtual machine At CliDriver.java:[line 137] |
| | org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliSessionState,
HiveConf, OptionsProcessor) concatenates strings using + in a loop At
CliDriver.java:using + in a loop At CliDriver.java:[line 832] |
| | org.apache.hadoop.hive.cli.CliDriver.processLine(String, boolean)
concatenates strings using + in a loop At CliDriver.java:+ in a loop At
CliDriver.java:[line 399] |
| FindBugs | module:itests/util |
| | org.apache.hadoop.hive.ql.QTestUtil.executeClientInternal(String)
concatenates strings using + in a loop At QTestUtil.java:in a loop At
QTestUtil.java:[line 1266] |
| | Format string should use %n rather than n in
org.apache.hadoop.hive.ql.QTestUtil.failedQuery(Throwable, int, String, String)
At QTestUtil.java:rather than n in
org.apache.hadoop.hive.ql.QTestUtil.failedQuery(Throwable, int, String, String)
At QTestUtil.java:[line 1981] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16930/dev-support/hive-personality.sh
|
| git revision | master / dfa1fc9 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16930/yetus/new-findbugs-cli.html
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16930/yetus/new-findbugs-itests_util.html
|
| modules | C: cli itests/util U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16930/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Have the actual error reported when a q test fails instead of having to go
> through the logs
> -------------------------------------------------------------------------------------------
>
> Key: HIVE-14669
> URL: https://issues.apache.org/jira/browse/HIVE-14669
> Project: Hive
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Laszlo Bodor
> Priority: Major
> Attachments: 01_mvn_out.png, 02_hive_log.png, HIVE-14469.01.patch,
> Screen Shot 2019-04-11 at 4.54.41 PM.png
>
>
> QTest runs end up invoking CliDriver.processLine. This, in most cases,
> reports a numeric exit code - 0 for success. Non-zero for various different
> error types (which are defined everywhere in the code).
> Internally CliDriver does have more information via CommandResult. A lot of
> this is not exposed though. That's alright for the end user cli - (Command
> line tool translating the error to a code and message). However, it makes
> debugging very difficult for QTests - since the log needs to be looked at
> each time.
> Errors generated by the actual backend execution are mostly available to the
> client, and information about these should show up as well. (If it doesn't -
> we have a usability issues to fix).
> cc [~ekoifman]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
