[
https://issues.apache.org/jira/browse/HIVE-21529?focusedWorklogId=227200&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-227200
]
ASF GitHub Bot logged work on HIVE-21529:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/19 17:34
Start Date: 13/Apr/19 17:34
Worklog Time Spent: 10m
Work Description: sankarh commented on pull request #581: HIVE-21529 :
Bootstrap ACID tables as part of incremental dump.
URL: https://github.com/apache/hive/pull/581#discussion_r275126022
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/CommitTxnHandler.java
##########
@@ -107,12 +107,33 @@ public void handle(Context withinContext) throws
Exception {
if
(!withinContext.hiveConf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY))
{
+ boolean replicatingAcidEvents = true;
+ if
(withinContext.hiveConf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES))
{
+ // We do not dump ACID table related events when taking a bootstrap
dump of ACID tables as
+ // part of an incremental dump. So we shouldn't be dumping any changes
to ACID table as
+ // part of the commit. At the same time we need to dump the commit
transaction event so
+ // that replication can end a transaction opened when replaying open
transaction event.
+ LOG.info("writeEventsInfoList will be removed from commit message
because we are " +
+ "bootstrapping acid tables.");
+ replicatingAcidEvents = false;
+ } else if
(withinContext.hiveConf.getBoolVar(HiveConf.ConfVars.HIVE_IN_TEST_REPL) &&
Review comment:
Need not check HIVE_IN_TEST_REPL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 227200)
> Hive support bootstrap of ACID/MM tables on an existing policy.
> ---------------------------------------------------------------
>
> Key: HIVE-21529
> URL: https://issues.apache.org/jira/browse/HIVE-21529
> Project: Hive
> Issue Type: Sub-task
> Components: repl, Transactions
> Affects Versions: 4.0.0
> Reporter: Sankar Hariappan
> Assignee: Ashutosh Bapat
> Priority: Major
> Labels: DR, pull-request-available, replication
> Attachments: HIVE-21529.01.patch, HIVE-21529.02.patch,
> HIVE-21529.03.patch
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> If ACID/MM tables to be enabled (hive.repl.dump.include.acid.tables) on an
> existing repl policy, then need to combine bootstrap dump of these tables
> along with the ongoing incremental dump.
> Shall add a one time config "hive.repl.bootstrap.acid.tables" to include
> bootstrap in the given dump.
> The support for hive.repl.bootstrap.cleanup.type for ACID tables to clean-up
> partially bootstrapped tables in case of retry is already in place, thanks to
> the work done during external tables. Need to test that it actually works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
