[
https://issues.apache.org/jira/browse/HIVE-21636?focusedWorklogId=230479&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230479
]
ASF GitHub Bot logged work on HIVE-21636:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/19 21:12
Start Date: 20/Apr/19 21:12
Worklog Time Spent: 10m
Work Description: bd2019us commented on pull request #599: [HIVE-21636]
ReplaceAll() -> replace() for non regex strings
URL: https://github.com/apache/hive/pull/599
[HIVE-21636](https://issues.apache.org/jira/browse/HIVE-21636) replaceAll()
to replace() where the extra regex compilation associated with replaceAll() is
not needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 230479)
Time Spent: 10m
Remaining Estimate: 0h
> Performance cost when using replaceAll() vs replace()
> ------------------------------------------------------
>
> Key: HIVE-21636
> URL: https://issues.apache.org/jira/browse/HIVE-21636
> Project: Hive
> Issue Type: Improvement
> Components: Accumulo Storage Handler, HCatalog, Vectorization
> Reporter: bd2019us
> Priority: Trivial
> Labels: pull-request-available
> Attachments: HVIE-21636.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Use String.replace() instead of String.replaceAll() when replaceAll() does
> not use a regex
> replace() does not need extra compilation / performance overhead when a
> non-regex string is used. Thus changing replaceAll() to replace() can remove
> the associated performance overhead.
> Affected files:
> #
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/compare/StringCompare.java
> #
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java
> # vector-code-gen/src/org/apache/hadoop/hive/tools/GenVectorCode.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
