[
https://issues.apache.org/jira/browse/HIVE-21570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823144#comment-16823144
]
slim bouguerra commented on HIVE-21570:
---------------------------------------
[~asinkovits] Thanks for doing this and sorry for late response. Can you please
submit a Pull request where i can add comments.
Here is 3 high level comments
* There is no need to wrap numeric values with StringValueOf, the json writer
can handle that plus it keep the typing correct.
* Lot of the HashMap creation can be avoided by using EnumMaps (maybe) since
we know all the keys upfront ?
* Missing some documentation about the query parameter and probably some
testing can you please provide examples and how might be used ?
Thanks
> Convert llap iomem servlets output to json format
> -------------------------------------------------
>
> Key: HIVE-21570
> URL: https://issues.apache.org/jira/browse/HIVE-21570
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Antal Sinkovits
> Assignee: Antal Sinkovits
> Priority: Minor
> Attachments: HIVE-21570.01.patch, HIVE-21570.02.patch,
> HIVE-21570.03.patch, HIVE-21570.04.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
