[ 
https://issues.apache.org/jira/browse/HIVE-21198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827016#comment-16827016
 ] 

Hive QA commented on HIVE-21198:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12967124/HIVE-21198.7.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 167 failed/errored test(s), 15934 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter1] (batchId=94)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_char1] (batchId=33)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_partition_coltype] 
(batchId=28)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_partition_onto_nocurrent_db]
 (batchId=96)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_partition_update_status]
 (batchId=98)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_rename_table] 
(batchId=34)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_skewed_table] 
(batchId=39)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_table_column_stats]
 (batchId=71)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_table_update_status]
 (batchId=87)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_table_update_status_disable_bitvector]
 (batchId=86)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_varchar1] 
(batchId=91)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_view_as_select] 
(batchId=11)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_view_rename] 
(batchId=41)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ambiguitycheck] 
(batchId=80)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[archive_multi] 
(batchId=34)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[columnstats_partlvl] 
(batchId=39)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[columnstats_tbllvl] 
(batchId=9)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_or_replace_view] 
(batchId=43)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_with_constraints] 
(batchId=75)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[describe_syntax] 
(batchId=87)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[describe_table] 
(batchId=47)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[display_colstats_tbllvl] 
(batchId=4)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert1] (batchId=26)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert2] (batchId=95)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert2_overwrite_partitions]
 (batchId=96)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_mr_pathalias] 
(batchId=86)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[rename_table_update_column_stats]
 (batchId=40)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[show_materialized_views] 
(batchId=15)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[temp_table_display_colstats_tbllvl]
 (batchId=85)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[temp_table_precedence] 
(batchId=91)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[touch] (batchId=70)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_drop_table_in_encrypted_db]
 (batchId=187)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_mv] 
(batchId=196)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[whroot_external1]
 (batchId=156)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[database] 
(batchId=168)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert1] 
(batchId=166)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_create_rewrite_3]
 (batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_create_rewrite_4]
 (batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_create_rewrite_5]
 (batchId=161)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_create_rewrite_rebuild_dummy]
 (batchId=168)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_create_rewrite_time_window]
 (batchId=163)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_create_rewrite_time_window_2]
 (batchId=177)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_partitioned]
 (batchId=184)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_rebuild]
 (batchId=183)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[update_access_time_non_current_db]
 (batchId=181)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[delete_non_acid_table]
 (batchId=102)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[materialized_view_authorization_rebuild_no_grant]
 (batchId=100)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[materialized_view_authorization_rebuild_other]
 (batchId=100)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[merge_negative_2]
 (batchId=100)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[mm_delete] 
(batchId=101)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[mm_update] 
(batchId=100)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[update_non_acid_table]
 (batchId=102)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert1] 
(batchId=123)
org.apache.hadoop.hive.ql.TestTxnCommands3.testRenameTable (batchId=332)
org.apache.hadoop.hive.ql.TestTxnExIm.testExportCustomDb (batchId=317)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.lockConflictDbTable 
(batchId=335)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMetastoreTablesCleanup 
(batchId=335)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testShowLocksFilterOptions 
(batchId=335)
org.apache.hadoop.hive.ql.parse.TestExportImport.dataImportAfterMetadataOnlyImport
 (batchId=260)
org.apache.hadoop.hive.ql.parse.TestExportImport.databaseTheTableIsImportedIntoShouldBeParsedFromCommandLine
 (batchId=260)
org.apache.hadoop.hive.ql.parse.TestExportImport.testExportExternalTableSetFalse
 (batchId=260)
org.apache.hadoop.hive.ql.parse.TestExportImport.testExportExternalTableSetTrue 
(batchId=260)
org.apache.hadoop.hive.ql.parse.TestQBCompact.testMajor (batchId=312)
org.apache.hadoop.hive.ql.parse.TestQBCompact.testMinor (batchId=312)
org.apache.hadoop.hive.ql.parse.TestQBCompact.testNonPartitionedTable 
(batchId=312)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testBasic 
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testBasicWithCM 
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testBootstrapLoadOnExistingDb
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testBootstrapWithConcurrentDropTable
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testBootstrapWithConcurrentRename
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testCMConflict 
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testConcatenatePartitionedTable
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testConcatenateTable
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testConstraints 
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testDropPartitionEventWithPartitionOnTimestampColumn
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testDrops 
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testDropsWithCM 
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testDumpLimit 
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testDumpWithPartitionDirMissing
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testEventTypesForDynamicAddPartitionByInsert
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testExchangePartition
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testIdempotentMoveTaskForInsertFiles
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testIncrementalAdds
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testIncrementalInsertDropPartitionedTable
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testIncrementalInsertDropUnpartitionedTable
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testIncrementalInsertToPartition
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testIncrementalInserts
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testIncrementalLoad
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testIncrementalLoadFailAndRetry
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testIncrementalLoadWithVariableLengthEventId
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testIncrementalRepeatEventOnExistingObject
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testIncrementalRepeatEventOnMissingObject
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testIncrementalReplWithEventsMissing
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testInsertOverwriteOnPartitionedTableWithCM
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testInsertOverwriteOnUnpartitionedTableWithCM
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testLoadCmPathMissing
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testMoveOptimizationIncremental
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testRecycleFileDropTempTable
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testRecycleFileNonReplDatabase
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testRemoveStats 
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testRenamePartitionWithCM
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testRenamePartitionedTableAcrossDatabases
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testRenameTableAcrossDatabases
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testRenameTableWithCM
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testStatus 
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testTableAlters 
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testTaskCreationOptimization
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testTruncatePartitionedTable
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testTruncateTable 
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testTruncateWithCM
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testViewsReplication
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.testWithStringPartitionSpecialChars
 (batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testBasic (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testBasicWithCM 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testBootstrapLoadOnExistingDb
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testBootstrapWithConcurrentDropTable
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testBootstrapWithConcurrentRename
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testCMConflict 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConcatenatePartitionedTable
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConcatenateTable 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testDropPartitionEventWithPartitionOnTimestampColumn
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testDrops (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testDropsWithCM 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testDumpLimit 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testDumpWithPartitionDirMissing
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testEventTypesForDynamicAddPartitionByInsert
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testExchangePartition 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testIdempotentMoveTaskForInsertFiles
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testIncrementalAdds 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testIncrementalInsertDropPartitionedTable
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testIncrementalInsertDropUnpartitionedTable
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testIncrementalInsertToPartition
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testIncrementalInserts 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testIncrementalLoad 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testIncrementalLoadFailAndRetry
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testIncrementalLoadWithVariableLengthEventId
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testIncrementalRepeatEventOnExistingObject
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testIncrementalRepeatEventOnMissingObject
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testIncrementalReplWithEventsMissing
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testInsertOverwriteOnPartitionedTableWithCM
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testInsertOverwriteOnUnpartitionedTableWithCM
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testLoadCmPathMissing 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testMoveOptimizationIncremental
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testRecycleFileDropTempTable
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testRecycleFileNonReplDatabase
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testRemoveStats 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testRenamePartitionWithCM
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testRenamePartitionedTableAcrossDatabases
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testRenameTableAcrossDatabases
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testRenameTableWithCM 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testStatus 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testTableAlters 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testTaskCreationOptimization
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testTruncatePartitionedTable
 (batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testTruncateTable 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testTruncateWithCM 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testViewsReplication 
(batchId=252)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testWithStringPartitionSpecialChars
 (batchId=252)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testDisableCompactionDuringReplLoad
 (batchId=243)
org.apache.hive.hcatalog.api.repl.commands.TestCommands.testBasicReplEximCommands
 (batchId=205)
org.apache.hive.hcatalog.api.repl.commands.TestCommands.testMetadataReplEximCommands
 (batchId=205)
org.apache.hive.hcatalog.streaming.TestStreaming.testNoBuckets (batchId=217)
org.apache.hive.streaming.TestStreaming.testAutoRollTransactionBatch 
(batchId=343)
org.apache.hive.streaming.TestStreaming.testCommitWithKeyValue (batchId=343)
org.apache.hive.streaming.TestStreaming.testConnectionWithWriteId (batchId=343)
org.apache.hive.streaming.TestStreaming.testNoBuckets (batchId=343)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/17051/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17051/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17051/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 167 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12967124 - PreCommit-HIVE-Build

> Introduce a database object reference class
> -------------------------------------------
>
>                 Key: HIVE-21198
>                 URL: https://issues.apache.org/jira/browse/HIVE-21198
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Zoltan Haindrich
>            Assignee: David Lavati
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21198.1.patch, HIVE-21198.2.patch, 
> HIVE-21198.3.patch, HIVE-21198.4.patch, HIVE-21198.5.patch, 
> HIVE-21198.6.patch, HIVE-21198.7.patch
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> There are many places in which "{databasename}.{tablename}" is passed as a 
> single string; there are some places where the they travel as 2 separate 
> arguments.
> Idea would be to introduce a simple immutable class with 2 fields ; and pass 
> these informations together. Making this better is required if we would be 
> wanting to enable dot in tablenames 
> HIVE-16907, HIVE-21151



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to