[ 
https://issues.apache.org/jira/browse/HIVE-21656?focusedWorklogId=234987&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234987
 ]

ASF GitHub Bot logged work on HIVE-21656:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Apr/19 23:48
            Start Date: 29/Apr/19 23:48
    Worklog Time Spent: 10m 
      Work Description: t3rmin4t0r commented on pull request #611: HIVE-21656: 
Vectorized Mask UDF
URL: https://github.com/apache/hive/pull/611#discussion_r279579121
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/UDFMaskVectorLong.java
 ##########
 @@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.exec.vector.expressions;
+
+import org.apache.hadoop.hive.ql.exec.vector.ColumnVector;
+import org.apache.hadoop.hive.ql.exec.vector.LongColumnVector;
+import org.apache.hadoop.hive.ql.exec.vector.VectorExpressionDescriptor;
+import org.apache.hadoop.hive.serde.serdeConstants;
+
+public class UDFMaskVectorLong extends UDFMaskBaseVector {
+
+  public UDFMaskVectorLong(int colNum, int outputColumnNum) {
+    super(colNum, outputColumnNum);
+  }
+
+  public UDFMaskVectorLong() {
+    super();
+  }
+
+  public void transform(ColumnVector outputColVector, ColumnVector 
inputVector, int idx) {
+    boolean isBooleanType =
+        
this.getInputTypeInfos()[0].getTypeName().equals(serdeConstants.BOOLEAN_TYPE_NAME);
+
+    // boolean data type is represented as long and masking is not supported 
for boolean
+    if(inputVector.isNull[idx] || isBooleanType) {
 
 Review comment:
   noNulls checking
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 234987)
    Time Spent: 20m  (was: 10m)

> Vectorize UDF mask
> ------------------
>
>                 Key: HIVE-21656
>                 URL: https://issues.apache.org/jira/browse/HIVE-21656
>             Project: Hive
>          Issue Type: Improvement
>          Components: Vectorization
>            Reporter: Vineet Garg
>            Assignee: Vineet Garg
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21656.1.patch, HIVE-21656.2.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to