[ 
https://issues.apache.org/jira/browse/HIVE-21586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829881#comment-16829881
 ] 

Hive QA commented on HIVE-21586:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12967415/HIVE-21586.04.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 15934 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/17073/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17073/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17073/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12967415 - PreCommit-HIVE-Build

> Thrift generated cpp files for metastore do not compile
> -------------------------------------------------------
>
>                 Key: HIVE-21586
>                 URL: https://issues.apache.org/jira/browse/HIVE-21586
>             Project: Hive
>          Issue Type: Bug
>          Components: Standalone Metastore
>    Affects Versions: 3.1.0
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Major
>             Fix For: 4.0.0, 3.2.0
>
>         Attachments: HIVE-21586.01.patch, HIVE-21586.02.patch, 
> HIVE-21586.03.patch, HIVE-21586.04.branch-3.patch, HIVE-21586.04.patch, 
> HIVE-21586.05.patch, HIVE-21586.nothrift.patch
>
>
> The way some structs like CreationMetadata, CompactionInfo, ColumnStatistics 
> are defined in hive_metastore.thrift is that these structs are used before 
> they are defined. While this works for the java code which is generated, it 
> does not work for the generated cpp code since Thrift does not use 
> pointer/references to the forward declared classes.
> The easy fix for this would be to reorder the struct definitions in the 
> hive_metastore.thrift so that they are always defined before they are used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to