[ 
https://issues.apache.org/jira/browse/HIVE-21671?focusedWorklogId=238377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-238377
 ]

ASF GitHub Bot logged work on HIVE-21671:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/May/19 11:31
            Start Date: 07/May/19 11:31
    Worklog Time Spent: 10m 
      Work Description: maheshk114 commented on pull request #615: HIVE-21671: 
Replicate Streaming ingestion with transactional batch size as 1.
URL: https://github.com/apache/hive/pull/615#discussion_r281448738
 
 

 ##########
 File path: 
streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java
 ##########
 @@ -686,6 +693,75 @@ private static IMetaStoreClient 
getMetaStoreClient(HiveConf conf, String metasto
     }
   }
 
+  private class WriteDirInfo {
+    List<String> partitionVals;
+    Path writeDir;
+
+    WriteDirInfo(List<String> partitionVals, Path writeDir) {
+      this.partitionVals = partitionVals;
+      this.writeDir = writeDir;
+    }
+
+    List<String> getPartitionVals() {
+      return this.partitionVals;
+    }
+
+    Path getWriteDir() {
+      return this.writeDir;
+    }
+  }
+
+  @Override
+  public void addWriteDirectoryInfo(List<String> partitionValues, Path 
writeDir) {
+    String key = (partitionValues == null) ? 
tableObject.getFullyQualifiedName()
+            : partitionValues.toString();
+    if (!writePaths.containsKey(key)) {
+      writePaths.put(key, new WriteDirInfo(partitionValues, writeDir));
 
 Review comment:
   what if for same partition value path is already there ..is it ok to ignore 
it ? i think assert can be added for writeDir to be same 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 238377)
    Time Spent: 40m  (was: 0.5h)

> Replicate Streaming ingestion with transactional batch size as 1.
> -----------------------------------------------------------------
>
>                 Key: HIVE-21671
>                 URL: https://issues.apache.org/jira/browse/HIVE-21671
>             Project: Hive
>          Issue Type: Sub-task
>          Components: repl, Streaming, Transactions
>    Affects Versions: 4.0.0
>            Reporter: Sankar Hariappan
>            Assignee: Sankar Hariappan
>            Priority: Major
>              Labels: DR, pull-request-available, replication
>         Attachments: HIVE-21671.01.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Replication streaming ingest HiveStreamingConnection on ACID tables with 
> transaction batch size as 1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to