[
https://issues.apache.org/jira/browse/HIVE-13582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835028#comment-16835028
]
Hive QA commented on HIVE-13582:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
5s{color} | {color:blue} ql in master has 2253 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
44s{color} | {color:red} ql: The patch generated 15 new + 539 unchanged - 38
fixed = 554 total (was 577) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 10 line(s) that end in whitespace. Use
git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 8 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
11s{color} | {color:red} ql generated 14 new + 2244 unchanged - 9 fixed = 2258
total (was 2253) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 25s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Switch statement found in
org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveSubQueryRemoveRule.rewriteInExists(RexSubQuery,
Set, RelOptUtil$Logic, HiveSubQRemoveRelBuilder, int, boolean) where one case
falls through to the next case At HiveSubQueryRemoveRule.java:Set,
RelOptUtil$Logic, HiveSubQRemoveRelBuilder, int, boolean) where one case falls
through to the next case At HiveSubQueryRemoveRule.java:[lines 460-463] |
| | Switch statement found in
org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveSubQueryRemoveRule.rewriteInExists(RexSubQuery,
Set, RelOptUtil$Logic, HiveSubQRemoveRelBuilder, int, boolean) where default
case is missing At HiveSubQueryRemoveRule.java:Set, RelOptUtil$Logic,
HiveSubQRemoveRelBuilder, int, boolean) where default case is missing At
HiveSubQueryRemoveRule.java:[lines 356-378] |
| | Dead store to stream_retval in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceSimilarExpressionQuantifierPredicate(CommonTree)
At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceSimilarExpressionQuantifierPredicate(CommonTree)
At HiveParser_IdentifiersParser.java:[line 9822] |
| | Dead store to stream_retval in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.quantifierType()
At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.quantifierType()
At HiveParser_IdentifiersParser.java:[line 9940] |
| | Redundant nullcheck of nonReserved311, which is known to be non-null in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.identifier()
Redundant null check at HiveParser_IdentifiersParser.java:is known to be
non-null in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.identifier()
Redundant null check at HiveParser_IdentifiersParser.java:[line 12308] |
| | Redundant nullcheck of retval, which is known to be non-null in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceSimilarExpressionQuantifierPredicate(CommonTree)
Redundant null check at HiveParser_IdentifiersParser.java:is known to be
non-null in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceSimilarExpressionQuantifierPredicate(CommonTree)
Redundant null check at HiveParser_IdentifiersParser.java:[line 9822] |
| | Redundant nullcheck of retval, which is known to be non-null in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.quantifierType()
Redundant null check at HiveParser_IdentifiersParser.java:is known to be
non-null in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.quantifierType()
Redundant null check at HiveParser_IdentifiersParser.java:[line 9940] |
| | Switch statement found in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.quantifierType()
where default case is missing At HiveParser_IdentifiersParser.java:where
default case is missing At HiveParser_IdentifiersParser.java:[lines
9924-10007] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA50
be a _static_ inner class? At HiveParser_IdentifiersParser.java:inner class?
At HiveParser_IdentifiersParser.java:[lines 36427-36440] |
| | Dead store to LA53_48 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA53.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA53.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36685] |
| | Dead store to LA53_56 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA53.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA53.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36698] |
| | Dead store to LA53_57 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA53.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA53.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36711] |
| | Dead store to LA53_58 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA53.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA53.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36724] |
| | Dead store to LA53_59 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA53.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA53.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36737] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17156/dev-support/hive-personality.sh
|
| git revision | master / 47aa61e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17156/yetus/diff-checkstyle-ql.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17156/yetus/whitespace-eol.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17156/yetus/whitespace-tabs.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17156/yetus/new-findbugs-ql.html
|
| modules | C: ql itests U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17156/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> E061-07 and E061-12: Quantified Comparison Predicates
> -----------------------------------------------------
>
> Key: HIVE-13582
> URL: https://issues.apache.org/jira/browse/HIVE-13582
> Project: Hive
> Issue Type: Sub-task
> Reporter: Carter Shanklin
> Assignee: Vineet Garg
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-13582.1.patch, HIVE-13582.2.patch,
> HIVE-13582.3.patch, HIVE-13582.4.patch, HIVE-13582.5.patch,
> HIVE-13582.6.patch, HIVE-13582.7.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> This is a part of the SQL:2011 Analytics Complete Umbrella JIRA HIVE-13554.
> Quantified comparison predicates (ANY/SOME/ALL) are mandatory in the SQL
> standard. Hive should support the predicates (E061-07) and you should be able
> to use these with subqueries (E061-12)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
