[ 
https://issues.apache.org/jira/browse/HIVE-11467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681255#comment-14681255
 ] 

Hive QA commented on HIVE-11467:
--------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12749692/HIVE-11467.04.patch

{color:green}SUCCESS:{color} +1 9348 tests passed

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4913/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4913/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4913/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12749692 - PreCommit-HIVE-TRUNK-Build

> WriteBuffers rounding wbSize to next power of 2 may cause OOM
> -------------------------------------------------------------
>
>                 Key: HIVE-11467
>                 URL: https://issues.apache.org/jira/browse/HIVE-11467
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>    Affects Versions: 1.2.0, 2.0.0
>            Reporter: Wei Zheng
>            Assignee: Wei Zheng
>         Attachments: HIVE-11467.01.patch, HIVE-11467.02.patch, 
> HIVE-11467.03.patch, HIVE-11467.04.patch
>
>
> If wbSize passed to WriteBuffers cstr is not power of 2, it will do a 
> rounding first to the next power of 2
> {code}
>   public WriteBuffers(int wbSize, long maxSize) {
>     this.wbSize = Integer.bitCount(wbSize) == 1 ? wbSize : 
> (Integer.highestOneBit(wbSize) << 1);
>     this.wbSizeLog2 = 31 - Integer.numberOfLeadingZeros(this.wbSize);
>     this.offsetMask = this.wbSize - 1;
>     this.maxSize = maxSize;
>     writePos.bufferIndex = -1;
>     nextBufferToWrite();
>   }
> {code}
> That may break existing memory consumption assumption for mapjoin, and 
> potentially cause OOM.
> The solution will be to pass a power of 2 number as wbSize from upstream 
> during hashtable creation, to avoid this late expansion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to