[
https://issues.apache.org/jira/browse/HIVE-21725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839882#comment-16839882
]
Hive QA commented on HIVE-21725:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12968716/HIVE-21725.03.patch
{color:green}SUCCESS:{color} +1 due to 5 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15979 tests
executed
*Failed tests:*
{noformat}
TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed
out) (batchId=185)
[vector_udf_adaptor_1.q,schema_evol_text_vec_part_llap_io.q,join_is_not_distinct_from.q,tez_schema_evolution.q,vector_multi_insert.q,input16_cc.q,materialized_view_rewrite_no_join_opt.q,temp_table.q,cross_product_check_2.q,partition_pruning.q,vectorization_17.q,materialized_view_create_rewrite_2.q,bucket_groupby.q,vector_nullsafe_join.q,vector_decimal_udf.q,materialized_view_rewrite_3.q,schema_evol_text_nonvec_part_all_primitive_llap_io.q,bucketpruning1.q,vector_groupby6.q,vector_char_varchar_1.q,smb_mapjoin_5.q,vector_char_4.q,auto_sortmerge_join_5.q,auto_join0.q,external_jdbc_table3.q,cbo_limit.q,vector_udf_inline.q,vector_windowing.q,schema_evol_orc_nonvec_part_all_primitive.q,auto_sortmerge_join_11.q]
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/17213/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17213/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17213/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12968716 - PreCommit-HIVE-Build
> Break up DDLTask - extract Column and Constraint related operations
> -------------------------------------------------------------------
>
> Key: HIVE-21725
> URL: https://issues.apache.org/jira/browse/HIVE-21725
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Affects Versions: 3.1.1
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: refactor-ddl
> Fix For: 4.0.0
>
> Attachments: HIVE-21725.01.patch, HIVE-21725.02.patch,
> HIVE-21725.03.patch
>
>
> DDLTask is a huge class, more than 5000 lines long. The related DDLWork is
> also a huge class, which has a field for each DDL operation it supports. The
> goal is to refactor these in order to have everything cut into more
> handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each operation
> * have a package for each operation group (database ddl, table ddl, etc), so
> the amount of classes under a package is more manageable
> * make all the requests (DDLDesc subclasses) immutable
> * DDLTask should be agnostic to the actual operations
> * right now let's ignore the issue of having some operations handled by
> DDLTask which are not actual DDL operations (lock, unlock, desc...)
> In the interim time when there are two DDLTask and DDLWork classes in the
> code base the new ones in the new package are called DDLTask2 and DDLWork2
> thus avoiding the usage of fully qualified class names where both the old and
> the new classes are in use.
> Step #9: extract all the column and constraint related operations from the
> old DDLTask, and move them under the new package each.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
