[ 
https://issues.apache.org/jira/browse/HIVE-21729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840308#comment-16840308
 ] 

Hive QA commented on HIVE-21729:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12968774/HIVE-21729.2.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 16010 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/17221/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17221/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17221/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12968774 - PreCommit-HIVE-Build

> Arrow serializer sometimes shifts timestamp by one second
> ---------------------------------------------------------
>
>                 Key: HIVE-21729
>                 URL: https://issues.apache.org/jira/browse/HIVE-21729
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 3.1.1
>            Reporter: Shubham Chaurasia
>            Assignee: Shubham Chaurasia
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21729.1.patch, HIVE-21729.2.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This happens due to 
> [secondInMicros|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/io/arrow/Serializer.java#L445]
>  are calculated like
> {code}
> final long secondInMicros = (secondInMillis - secondInMillis % 
> MILLIS_PER_SECOND) * MICROS_PER_MILLIS;
> {code}
> Instead this should be calculated like(by taking nanos from 
> timestampColumnVector itself)
> {code}
> final long nanos = timestampColumnVector.getNanos(j);
> final long secondInMicros = (secondInMillis - nanos / NS_PER_MILLIS) * 
> MICROS_PER_MILLIS;
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to