[ 
https://issues.apache.org/jira/browse/HIVE-21776?focusedWorklogId=247846&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-247846
 ]

ASF GitHub Bot logged work on HIVE-21776:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/May/19 03:42
            Start Date: 24/May/19 03:42
    Worklog Time Spent: 10m 
      Work Description: sankarh commented on pull request #642: HIVE-21776 : 
Replication fails to replicate a UDF with jar on HDFS during incremental
URL: https://github.com/apache/hive/pull/642#discussion_r287206089
 
 

 ##########
 File path: 
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java
 ##########
 @@ -356,6 +356,9 @@ public static FileInfo getFileInfo(Path src, String 
checksumString, String srcCM
   // Currently using fileuri#checksum#cmrooturi#subdirs as the format
   public static String encodeFileUri(String fileUriStr, String fileChecksum, 
String encodedSubDir)
           throws IOException {
+    if (instance == null) {
 
 Review comment:
   It can be assert as we expect caller to always instantiate ReplChangeManager 
before invoking this method.
   Also, if you think, exception is better, then shall use 
IllegalStateException to be relevant.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 247846)
    Time Spent: 20m  (was: 10m)

> Replication fails to replicate a UDF with jar on HDFS during incremental
> ------------------------------------------------------------------------
>
>                 Key: HIVE-21776
>                 URL: https://issues.apache.org/jira/browse/HIVE-21776
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 4.0.0
>            Reporter: Ashutosh Bapat
>            Assignee: Ashutosh Bapat
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21776.01.patch, HIVE-21776.02.patch, 
> HIVE-21776.03.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> TestReplicationScenariosAcrossInstances has test to test bootstrap of a UDF 
> with jar on HDFS but no test for incremental. Add the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to