[
https://issues.apache.org/jira/browse/HIVE-21753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848085#comment-16848085
]
Hive QA commented on HIVE-21753:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
48s{color} | {color:blue} ql in master has 2258 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
11s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
51s{color} | {color:red} ql: The patch generated 242 new + 4 unchanged - 0
fixed = 246 total (was 4) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 5m
0s{color} | {color:red} ql generated 6 new + 2258 unchanged - 0 fixed = 2264
total (was 2258) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 45s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Switch statement found in
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.HiveMetaStoreAuthorizer.isViewOperation(PreEventContext)
where default case is missing At HiveMetaStoreAuthorizer.java:where default
case is missing At HiveMetaStoreAuthorizer.java:[lines 210-225] |
| |
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events.AddPartitionEvent.buildCommandString(String,
Table) concatenates strings using + in a loop At AddPartitionEvent.java:+ in
a loop At AddPartitionEvent.java:[line 104] |
| | Null passed for non-null parameter of
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.HiveMetaStoreAuthorizableEvent.getHivePrivilegeObject(Database)
in
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events.AlterDatabaseEvent.getOutputHObjs()
Method invoked at AlterDatabaseEvent.java:of
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.HiveMetaStoreAuthorizableEvent.getHivePrivilegeObject(Database)
in
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events.AlterDatabaseEvent.getOutputHObjs()
Method invoked at AlterDatabaseEvent.java:[line 82] |
| | Nullcheck of database at line 82 of value previously dereferenced in
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events.AlterDatabaseEvent.getOutputHObjs()
At AlterDatabaseEvent.java:82 of value previously dereferenced in
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events.AlterDatabaseEvent.getOutputHObjs()
At AlterDatabaseEvent.java:[line 82] |
| | Null passed for non-null parameter of
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.HiveMetaStoreAuthorizableEvent.getHivePrivilegeObject(Database)
in
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events.CreateDatabaseEvent.getOutputHObjs()
Method invoked at CreateDatabaseEvent.java:of
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.HiveMetaStoreAuthorizableEvent.getHivePrivilegeObject(Database)
in
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events.CreateDatabaseEvent.getOutputHObjs()
Method invoked at CreateDatabaseEvent.java:[line 69] |
| |
org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events.DropPartitionEvent.buildCommandString(String,
Table) concatenates strings using + in a loop At DropPartitionEvent.java:+ in
a loop At DropPartitionEvent.java:[line 90] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17311/dev-support/hive-personality.sh
|
| git revision | master / 728b385 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17311/yetus/diff-checkstyle-ql.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17311/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17311/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Update HiveMetastore authorization to enable use of HiveAuthorizer
> implementation
> ---------------------------------------------------------------------------------
>
> Key: HIVE-21753
> URL: https://issues.apache.org/jira/browse/HIVE-21753
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Affects Versions: 3.1.2
> Reporter: Ramesh Mani
> Assignee: Ramesh Mani
> Priority: Critical
> Labels: pull-request-available
> Attachments: HIVE-21753.1.patch, HIVE-21753.2.patch,
> HIVE-21753.3.patch
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Currently HMS supports authorization using StorageBasedAuthorizationProvider
> which relies on permissions at filesystem – like HDFS. Hive supports a
> pluggable authorization interface, and multiple authorizer implementations
> (like SQLStd, Ranger, Sentry) are available to authorizer access in Hive.
> Extending HiveMetastore to use the same authorization interface as Hive will
> enable use of pluggable authorization implementations; and will result in
> consistent authorization across Hive, HMS and other services that use HMS
> (like Spark).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
