[
https://issues.apache.org/jira/browse/HIVE-21787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851005#comment-16851005
]
Hive QA commented on HIVE-21787:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
25s{color} | {color:blue} standalone-metastore/metastore-server in master has
183 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
24s{color} | {color:red} standalone-metastore/metastore-server: The patch
generated 98 new + 206 unchanged - 3 fixed = 304 total (was 209) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
1s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
1s{color} | {color:red} The patch 1 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
37s{color} | {color:red} standalone-metastore/metastore-server generated 6 new
+ 178 unchanged - 5 fixed = 184 total (was 183) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 18m 14s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
| | Write to static field
org.apache.hadoop.hive.metastore.cache.CachedStore.sharedCache from instance
method
org.apache.hadoop.hive.metastore.cache.CachedStore.setSharedCache(SharedCache)
At CachedStore.java:from instance method
org.apache.hadoop.hive.metastore.cache.CachedStore.setSharedCache(SharedCache)
At CachedStore.java:[line 152] |
| | Incorrect lazy initialization of static field
org.apache.hadoop.hive.metastore.cache.SharedCache.sizeEstimators in
org.apache.hadoop.hive.metastore.cache.SharedCache.initialize(Configuration,
int, int) At SharedCache.java:field
org.apache.hadoop.hive.metastore.cache.SharedCache.sizeEstimators in
org.apache.hadoop.hive.metastore.cache.SharedCache.initialize(Configuration,
int, int) At SharedCache.java:[lines 200-201] |
| | Redundant nullcheck of tblWrapper, which is known to be non-null in
org.apache.hadoop.hive.metastore.cache.SharedCache.removeTableFromCache(String,
String, String) Redundant null check at SharedCache.java:is known to be
non-null in
org.apache.hadoop.hive.metastore.cache.SharedCache.removeTableFromCache(String,
String, String) Redundant null check at SharedCache.java:[line 1543] |
| | Write to static field
org.apache.hadoop.hive.metastore.cache.SharedCache.maxCacheSizeInBytes from
instance method
org.apache.hadoop.hive.metastore.cache.SharedCache.initialize(Configuration,
int, int) At SharedCache.java:from instance method
org.apache.hadoop.hive.metastore.cache.SharedCache.initialize(Configuration,
int, int) At SharedCache.java:[line 197] |
| | Write to static field
org.apache.hadoop.hive.metastore.cache.SharedCache.sizeEstimators from instance
method
org.apache.hadoop.hive.metastore.cache.SharedCache.initialize(Configuration,
int, int) At SharedCache.java:from instance method
org.apache.hadoop.hive.metastore.cache.SharedCache.initialize(Configuration,
int, int) At SharedCache.java:[line 201] |
| | Unread field:SharedCache.java:[line 177] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17339/dev-support/hive-personality.sh
|
| git revision | master / a26dc36 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17339/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17339/yetus/whitespace-eol.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17339/yetus/whitespace-tabs.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17339/yetus/new-findbugs-standalone-metastore_metastore-server.html
|
| modules | C: standalone-metastore/metastore-server U:
standalone-metastore/metastore-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17339/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Metastore table cache enhancement
> ---------------------------------
>
> Key: HIVE-21787
> URL: https://issues.apache.org/jira/browse/HIVE-21787
> Project: Hive
> Issue Type: New Feature
> Components: Standalone Metastore
> Reporter: Sam An
> Assignee: Sam An
> Priority: Major
> Attachments: HIVE-21787.1.patch
>
>
> Metastore currently uses black/white list to specify patterns of tables to
> load into the cache. Cache is loaded in one shot "prewarm", and updated by a
> background thread. This is not a very efficient design.
> In this feature, we try to enhance the cache for Tables with LRU to improve
> cache utilization.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
