[
https://issues.apache.org/jira/browse/HIVE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851780#comment-16851780
]
Laszlo Bodor commented on HIVE-21789:
-------------------------------------
+1
as far as I can see, the same logic is handled in
HiveFileFormatUtils.getHiveOutputFormat in all occurences, so yes, handling the
same in getRecordWriter is duplicate from this point of view
> HiveFileFormatUtils.getRecordWriter is unnecessary
> --------------------------------------------------
>
> Key: HIVE-21789
> URL: https://issues.apache.org/jira/browse/HIVE-21789
> Project: Hive
> Issue Type: Improvement
> Reporter: Ivan Suller
> Assignee: Ivan Suller
> Priority: Minor
> Attachments: HIVE-21789.1.patch
>
>
> The method org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getRecordWriter
> checks if the given outputFormat parameter is a HiveOutputFormat, but it is
> always true. So this way the check and thus the method is unnecessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
