[ https://issues.apache.org/jira/browse/HIVE-10631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693936#comment-14693936 ]
Hive QA commented on HIVE-10631: -------------------------------- {color:red}Overall{color}: -1 no tests executed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12750006/HIVE-10631.patch Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4936/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4936/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4936/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n /usr/java/jdk1.7.0_45-cloudera ]] + export JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera + JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera + export PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin + PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + cd /data/hive-ptest/working/ + tee /data/hive-ptest/logs/PreCommit-HIVE-TRUNK-Build-4936/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + cd apache-github-source-source + git fetch origin >From https://github.com/apache/hive a6d3070..425273e branch-1 -> origin/branch-1 cafd555..a4eb78c branch-1.0 -> origin/branch-1.0 2ee30c4..0140df7 master -> origin/master + git reset --hard HEAD HEAD is now at 2ee30c4 HIVE-11449: "Capacity must be a power of two" error when HybridHashTableContainer memory threshold is too low (Jason Dere, reviewed by Sergey Shelukhin) + git clean -f -d + git checkout master Already on 'master' Your branch is behind 'origin/master' by 3 commits, and can be fast-forwarded. + git reset --hard origin/master HEAD is now at 0140df7 HIVE-11480: CBO: Calcite Operator To Hive Operator (Calcite Return Path): char/varchar as input to GenericUDAF (Pengcheng Xiong, reviewed by Jesus Camacho Rodriguez) + git merge --ff-only origin/master Already up-to-date. + git gc + patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hive-ptest/working/scratch/build.patch + [[ -f /data/hive-ptest/working/scratch/build.patch ]] + chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh + /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch The patch does not appear to apply with p0, p1, or p2 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12750006 - PreCommit-HIVE-TRUNK-Build > create_table_core method has invalid update for Fast Stats > ---------------------------------------------------------- > > Key: HIVE-10631 > URL: https://issues.apache.org/jira/browse/HIVE-10631 > Project: Hive > Issue Type: Bug > Components: Metastore > Affects Versions: 1.0.0 > Reporter: Dongwook Kwon > Assignee: Aaron Tokhy > Priority: Minor > Attachments: HIVE-10631.patch > > > HiveMetaStore.create_table_core method calls > MetaStoreUtils.updateUnpartitionedTableStatsFast when hive.stats.autogather > is on, however for partitioned table, this updateUnpartitionedTableStatsFast > call scanning warehouse dir and doesn't seem to use it. > "Fast Stats" was implemented by HIVE-3959 > https://github.com/apache/hive/blob/branch-1.0/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L1363 > From create_table_core method > {code} > if (HiveConf.getBoolVar(hiveConf, > HiveConf.ConfVars.HIVESTATSAUTOGATHER) && > !MetaStoreUtils.isView(tbl)) { > if (tbl.getPartitionKeysSize() == 0) { // Unpartitioned table > MetaStoreUtils.updateUnpartitionedTableStatsFast(db, tbl, wh, > madeDir); > } else { // Partitioned table with no partitions. > MetaStoreUtils.updateUnpartitionedTableStatsFast(db, tbl, wh, > true); > } > } > {code} > Particularly Line 1363: // Partitioned table with no partitions. > {code} > MetaStoreUtils.updateUnpartitionedTableStatsFast(db, tbl, wh, true); > {code} > This call ends up calling Warehouse.getFileStatusesForUnpartitionedTable and > do nothing in MetaStoreUtils.updateUnpartitionedTableStatsFast method due to > newDir flag is always true > Impact of this bug is minor with HDFS warehouse > location(hive.metastore.warehouse.dir), it could be big with S3 warehouse > location especially for large existing partitions. > Also the impact is heighten with HIVE-6727 when warehouse location is S3, > basically it could scan wrong S3 directory recursively and do nothing with > it. I will add more detail of cases in comments -- This message was sent by Atlassian JIRA (v6.3.4#6332)