[
https://issues.apache.org/jira/browse/HIVE-21891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868022#comment-16868022
]
Hive QA commented on HIVE-21891:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12972245/HIVE-21891.04.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/17658/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17658/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17658/
Messages:
{noformat}
**** This message was trimmed, see log for full details ****
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AbstractConstraintEventHandler.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AddPartitionHandler.java:67
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AddPartitionHandler.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AlterPartitionHandler.java:100
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AlterPartitionHandler.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AlterTableHandler.java:88
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AlterTableHandler.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/CommitTxnHandler.java:113
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/CommitTxnHandler.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/CreateTableHandler.java:54
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/CreateTableHandler.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/EventHandler.java:41
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/EventHandler.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/InsertHandler.java:58
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/InsertHandler.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/UpdatePartColStatHandler.java:52
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/UpdatePartColStatHandler.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/UpdateTableColStatHandler.java:37
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/UpdateTableColStatHandler.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/TableSerializer.java:52
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/TableSerializer.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java:19
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java:146
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java' cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRegExp.java:23
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRegExp.java'
cleanly.
error: patch failed:
ql/src/test/org/apache/hadoop/hive/ql/exec/repl/TestReplDumpTask.java:139
Falling back to three-way merge...
Applied patch to
'ql/src/test/org/apache/hadoop/hive/ql/exec/repl/TestReplDumpTask.java' cleanly.
error: patch failed:
ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q:5
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q'
cleanly.
error: patch failed:
ql/src/test/queries/clientpositive/auto_sortmerge_join_11.q:4
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/auto_sortmerge_join_11.q'
cleanly.
error: patch failed:
ql/src/test/queries/clientpositive/auto_sortmerge_join_12.q:5
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/auto_sortmerge_join_12.q'
cleanly.
error: patch failed:
ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q:17
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q'
cleanly.
error: patch failed:
ql/src/test/queries/clientpositive/auto_sortmerge_join_2.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/auto_sortmerge_join_2.q'
cleanly.
error: patch failed:
ql/src/test/queries/clientpositive/auto_sortmerge_join_3.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/auto_sortmerge_join_3.q'
cleanly.
error: patch failed:
ql/src/test/queries/clientpositive/auto_sortmerge_join_4.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/auto_sortmerge_join_4.q'
cleanly.
error: patch failed:
ql/src/test/queries/clientpositive/auto_sortmerge_join_5.q:6
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/auto_sortmerge_join_5.q'
cleanly.
error: patch failed:
ql/src/test/queries/clientpositive/auto_sortmerge_join_7.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/auto_sortmerge_join_7.q'
cleanly.
error: patch failed:
ql/src/test/queries/clientpositive/auto_sortmerge_join_8.q:6
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/auto_sortmerge_join_8.q'
cleanly.
error: patch failed: ql/src/test/queries/clientpositive/bucketcontext_1.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/bucketcontext_1.q' cleanly.
error: patch failed: ql/src/test/queries/clientpositive/bucketcontext_2.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/bucketcontext_2.q' cleanly.
error: patch failed: ql/src/test/queries/clientpositive/bucketcontext_3.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/bucketcontext_3.q' cleanly.
error: patch failed: ql/src/test/queries/clientpositive/bucketcontext_4.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/bucketcontext_4.q' cleanly.
error: patch failed: ql/src/test/queries/clientpositive/bucketcontext_5.q:2
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/bucketcontext_5.q' cleanly.
error: patch failed: ql/src/test/queries/clientpositive/bucketcontext_6.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/bucketcontext_6.q' cleanly.
error: patch failed: ql/src/test/queries/clientpositive/bucketcontext_7.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/bucketcontext_7.q' cleanly.
error: patch failed: ql/src/test/queries/clientpositive/bucketcontext_8.q:3
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/bucketcontext_8.q' cleanly.
error: patch failed:
ql/src/test/queries/clientpositive/bucketizedhiveinputformat_auto.q:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/queries/clientpositive/bucketizedhiveinputformat_auto.q' cleanly.
error: patch failed: ql/src/test/results/clientpositive/bucketcontext_1.q.out:1
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/bucketcontext_1.q.out'
cleanly.
error: patch failed: ql/src/test/results/clientpositive/bucketcontext_2.q.out:1
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/bucketcontext_2.q.out'
cleanly.
error: patch failed: ql/src/test/results/clientpositive/bucketcontext_3.q.out:1
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/bucketcontext_3.q.out'
cleanly.
error: patch failed: ql/src/test/results/clientpositive/bucketcontext_4.q.out:1
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/bucketcontext_4.q.out'
cleanly.
error: patch failed: ql/src/test/results/clientpositive/bucketcontext_5.q.out:1
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/bucketcontext_5.q.out'
cleanly.
error: patch failed: ql/src/test/results/clientpositive/bucketcontext_6.q.out:1
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/bucketcontext_6.q.out'
cleanly.
error: patch failed: ql/src/test/results/clientpositive/bucketcontext_7.q.out:1
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/bucketcontext_7.q.out'
cleanly.
error: patch failed: ql/src/test/results/clientpositive/bucketcontext_8.q.out:1
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/bucketcontext_8.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/bucketizedhiveinputformat_auto.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/bucketizedhiveinputformat_auto.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/llap/alter_partition_change_col.q.out:253
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/alter_partition_change_col.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/llap/auto_sortmerge_join_1.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/auto_sortmerge_join_1.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/llap/auto_sortmerge_join_16.q.out:4
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/auto_sortmerge_join_16.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/llap/auto_sortmerge_join_2.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/auto_sortmerge_join_2.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/llap/auto_sortmerge_join_3.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/auto_sortmerge_join_3.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/llap/auto_sortmerge_join_4.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/auto_sortmerge_join_4.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/llap/auto_sortmerge_join_5.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/auto_sortmerge_join_5.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/llap/auto_sortmerge_join_7.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/auto_sortmerge_join_7.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/llap/auto_sortmerge_join_8.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/llap/auto_sortmerge_join_8.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_1.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/auto_sortmerge_join_1.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_16.q.out:4
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/auto_sortmerge_join_16.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_16.q.out_spark:4
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/auto_sortmerge_join_16.q.out_spark'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_2.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/auto_sortmerge_join_2.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_3.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/auto_sortmerge_join_3.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_4.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/auto_sortmerge_join_4.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_5.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/auto_sortmerge_join_5.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_7.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/auto_sortmerge_join_7.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_8.q.out:1
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/auto_sortmerge_join_8.q.out' cleanly.
error: patch failed:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/repl/ReplScope.java:29
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/repl/ReplScope.java'
cleanly.
U ql/pom.xml
warning: 4 lines add whitespace errors.
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-17658
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12972245 - PreCommit-HIVE-Build
> Break up DDLTask - cleanup
> --------------------------
>
> Key: HIVE-21891
> URL: https://issues.apache.org/jira/browse/HIVE-21891
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Affects Versions: 3.1.1
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: refactor-ddl
> Fix For: 4.0.0
>
> Attachments: HIVE-21891.01.patch, HIVE-21891.02.patch,
> HIVE-21891.03.patch, HIVE-21891.04.patch, HIVE-21891.04.patch
>
>
> DDLTask was a huge class, more than 5000 lines long. The related DDLWork was
> also a huge class, which had a field for each DDL operation it supported. The
> goal was to refactor these in order to have everything cut into more
> handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
> * have a separate class for each operation
> * have a package for each operation group (database ddl, table ddl, etc), so
> the amount of classes under a package is more manageable
> * make all the requests (DDLDesc subclasses) immutable - most of them are now
> * DDLTask should be agnostic to the actual operations
> * right now let's ignore the issue of having some operations handled by
> DDLTask which are not actual DDL operations (lock, unlock, desc...)
> In the interim time when there were two DDLTask and DDLWork classes in the
> code base the new ones in the new package were called DDLTask2 and DDLWork2
> thus avoiding the usage of fully qualified class names where both the old and
> the new classes were in use.
> Step #12: rename DDLTask2 and DDLWork2, now that they are alone. Remove the
> old DDLDesc. Instead of registering, now DDLTask finds the DDLOperations, and
> registers them itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
