[ 
https://issues.apache.org/jira/browse/HIVE-21907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871764#comment-16871764
 ] 

Hive QA commented on HIVE-21907:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m  
3s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
32s{color} | {color:blue} llap-common in master has 84 extant Findbugs 
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
47s{color} | {color:blue} llap-server in master has 82 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
20s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
19s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 19s{color} 
| {color:red} llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
16s{color} | {color:red} llap-server: The patch generated 13 new + 168 
unchanged - 0 fixed = 181 total (was 168) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 10 line(s) that end in whitespace. Use 
git apply --whitespace=fix <<patch_file>>. Refer 
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
41s{color} | {color:red} llap-common generated 6 new + 84 unchanged - 0 fixed = 
90 total (was 84) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
20s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m  7s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:llap-common |
|  |  
org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$SetCapacityRequestProto.PARSER
 isn't final but should be  At LlapDaemonProtocolProtos.java:be  At 
LlapDaemonProtocolProtos.java:[line 21807] |
|  |  Class 
org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$SetCapacityRequestProto
 defines non-transient non-serializable instance field unknownFields  In 
LlapDaemonProtocolProtos.java:instance field unknownFields  In 
LlapDaemonProtocolProtos.java |
|  |  Useless control flow in 
org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$SetCapacityRequestProto$Builder.maybeForceBuilderInitialization()
  At LlapDaemonProtocolProtos.java: At LlapDaemonProtocolProtos.java:[line 
22048] |
|  |  
org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$SetCapacityResponseProto.PARSER
 isn't final but should be  At LlapDaemonProtocolProtos.java:be  At 
LlapDaemonProtocolProtos.java:[line 22300] |
|  |  Class 
org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$SetCapacityResponseProto
 defines non-transient non-serializable instance field unknownFields  In 
LlapDaemonProtocolProtos.java:instance field unknownFields  In 
LlapDaemonProtocolProtos.java |
|  |  Useless control flow in 
org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$SetCapacityResponseProto$Builder.maybeForceBuilderInitialization()
  At LlapDaemonProtocolProtos.java: At LlapDaemonProtocolProtos.java:[line 
22474] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17713/dev-support/hive-personality.sh
 |
| git revision | master / 6ae593e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17713/yetus/patch-mvninstall-llap-server.txt
 |
| compile | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17713/yetus/patch-compile-llap-server.txt
 |
| javac | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17713/yetus/patch-compile-llap-server.txt
 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17713/yetus/diff-checkstyle-llap-server.txt
 |
| whitespace | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17713/yetus/whitespace-eol.txt
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17713/yetus/new-findbugs-llap-common.html
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17713/yetus/patch-findbugs-llap-server.txt
 |
| modules | C: llap-common llap-server U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17713/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Add a new LlapDaemon Management API method to set the daemon capacity
> ---------------------------------------------------------------------
>
>                 Key: HIVE-21907
>                 URL: https://issues.apache.org/jira/browse/HIVE-21907
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21907.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Add a new method to LlapManagementProtocol API which can disable an Llap node.
> It would be even better, if we can dynamically set the number of executors 
> and the size of the wait queue. This way we can disable the node setting them 
> to 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to