[
https://issues.apache.org/jira/browse/HIVE-21846?focusedWorklogId=267312&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-267312
]
ASF GitHub Bot logged work on HIVE-21846:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jun/19 07:09
Start Date: 26/Jun/19 07:09
Worklog Time Spent: 10m
Work Description: asinkovits commented on pull request #683: HIVE-21846:
Create a thread in TezAM which periodically fetches LlapDaemon metrics
URL: https://github.com/apache/hive/pull/683#discussion_r297512929
##########
File path:
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
##########
@@ -790,6 +794,8 @@ public void run() {
}
}, 0, 10000L, TimeUnit.MILLISECONDS);
+ llapMetricsCollector.start();
Review comment:
Now this is a bit tricky. I didn't wanted to do a tight coupling between the
registry and the collector, but I agree that there is a dependency between the
starts. So I've added the ServiceStateChangeListener to the Collector, and
subscribed to the state changes of the registry. This way we can ensure, that
the starts and stops happen in the correct way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 267312)
Time Spent: 1h 50m (was: 1h 40m)
> Create a thread in TezAM which periodically fetches LlapDaemon metrics
> ----------------------------------------------------------------------
>
> Key: HIVE-21846
> URL: https://issues.apache.org/jira/browse/HIVE-21846
> Project: Hive
> Issue Type: Sub-task
> Components: llap, Tez
> Reporter: Peter Vary
> Assignee: Antal Sinkovits
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21846.01.patch, HIVE-21846.02.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> LlapTaskSchedulerService should start a thread which periodically fetches the
> LlapDaemon metrics and stores them in the NodeInfo object.
> This should be just the first implementation - later we should find a way
> where we do not need NxM requests between N TezAM and M LlapDaemon
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
