[ 
https://issues.apache.org/jira/browse/HIVE-21878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873108#comment-16873108
 ] 

Peter Vary commented on HIVE-21878:
-----------------------------------

[~jdere]: Thanks for the patch!

Few minor comments:
 * Probably it would be better to use gauge instead of counter 
([https://copperegg.zendesk.com/hc/en-us/articles/214635123-Data-types-for-custom-metrics-gauges-vs-counters])
 * Maybe accidentally you changed to '*' based import.

Other than that LGTM.

Thanks,

Peter

> Metric for AM to show whether it is currently running a DAG
> -----------------------------------------------------------
>
>                 Key: HIVE-21878
>                 URL: https://issues.apache.org/jira/browse/HIVE-21878
>             Project: Hive
>          Issue Type: Bug
>          Components: Tez
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>            Priority: Major
>         Attachments: HIVE-21878.1.patch, HIVE-21878.1.patch
>
>
> Add a basic gauge metric to indicate whether a Tez AM is currently running a 
> DAG for a Hive query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to