[
https://issues.apache.org/jira/browse/HIVE-21911?focusedWorklogId=270037&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-270037
]
ASF GitHub Bot logged work on HIVE-21911:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/19 08:40
Start Date: 01/Jul/19 08:40
Worklog Time Spent: 10m
Work Description: pvary commented on pull request #691: HIVE-21911:
Pluggable LlapMetricsListener on Tez side to disable / resize Daemons
URL: https://github.com/apache/hive/pull/691#discussion_r298936551
##########
File path:
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapMetricsCollector.java
##########
@@ -101,13 +122,27 @@ void collectMetrics() {
LlapDaemonProtocolProtos.GetDaemonMetricsResponseProto metrics =
client.getDaemonMetrics(null,
LlapDaemonProtocolProtos.GetDaemonMetricsRequestProto.newBuilder().build());
- instanceStatisticsMap.put(identity, new LlapMetrics(metrics));
-
+ LlapMetrics newMetrics = new LlapMetrics(metrics);
Review comment:
Yes, I see several use-cases where we need statistics without the listener.
For example: it might be good idea that when we chose a random node for task
execution we could distribute these tasks based on the available executors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 270037)
Time Spent: 1h 10m (was: 1h)
> Pluggable LlapMetricsListener on Tez side to disable / resize Daemons
> ---------------------------------------------------------------------
>
> Key: HIVE-21911
> URL: https://issues.apache.org/jira/browse/HIVE-21911
> Project: Hive
> Issue Type: Sub-task
> Components: llap, Tez
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21911.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We need to have a way to plug in different listeners which act upon the
> LlapDaemon statistics.
> This listener should be able to disable / resize the LlapDaemons based on
> health data.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
