[
https://issues.apache.org/jira/browse/HIVE-21909?focusedWorklogId=271304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-271304
]
ASF GitHub Bot logged work on HIVE-21909:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/19 00:36
Start Date: 03/Jul/19 00:36
Worklog Time Spent: 10m
Work Description: odraese commented on pull request #695: HIVE-21909:
Publish the LLAP Daemon capacity through ZooKeeper and ho…
URL: https://github.com/apache/hive/pull/695#discussion_r299604870
##########
File path:
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java
##########
@@ -132,6 +136,12 @@ private void unregisterWorker() throws IOException {
}
}
+ public void updateRegistration(Iterable<Map.Entry<String, String>>
attributes) throws IOException {
+ if (isDaemon && this.registry != null) {
Review comment:
Question: Why only if isDaemon=true? Other register/unregister only care
about registry != null...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 271304)
Time Spent: 0.5h (was: 20m)
> Publish the LLAP Daemon capacity through ZooKeeper and honor the capacity
> when scheduling new tasks
> ---------------------------------------------------------------------------------------------------
>
> Key: HIVE-21909
> URL: https://issues.apache.org/jira/browse/HIVE-21909
> Project: Hive
> Issue Type: Sub-task
> Components: llap
> Reporter: Peter Vary
> Assignee: Antal Sinkovits
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21909.01.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The changes in LlapDaemonNode status (or executor number) should be reflected
> in the ZooKeeper information, and we should make sure TezAMs are reading and
> honor the changes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
