[
https://issues.apache.org/jira/browse/HIVE-21908?focusedWorklogId=272105&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-272105
]
ASF GitHub Bot logged work on HIVE-21908:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/19 09:55
Start Date: 04/Jul/19 09:55
Worklog Time Spent: 10m
Work Description: asinkovits commented on pull request #699: HIVE-21908:
LlapDaemon node status should be reflected in the metrics
URL: https://github.com/apache/hive/pull/699#discussion_r300324355
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/metrics/LlapDaemonExecutorInfo.java
##########
@@ -64,6 +64,8 @@
ExecutorFallOffNumCompletedFragments("Number of completed fragments w.r.t
falloff values"),
AverageQueueTime("Average queue time for tasks"),
AverageResponseTime("Average response time for successful tasks"),
+ NumExecutorsEnabled("The number of executor threads enabled"),
+ WaitQueueSizeEnabled("Size of wait queue enabled"),
Review comment:
We already have a ExecutorWaitQueueSize("Size of wait queue per node"),
which is the original wait queue size. (Now it should be something like wait
queue max or something)
Should we rework the naming?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 272105)
Time Spent: 40m (was: 0.5h)
> LlapDaemon node status should be reflected in the metrics
> ---------------------------------------------------------
>
> Key: HIVE-21908
> URL: https://issues.apache.org/jira/browse/HIVE-21908
> Project: Hive
> Issue Type: Sub-task
> Components: llap
> Reporter: Peter Vary
> Assignee: Antal Sinkovits
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21908.01.patch, HIVE-21908.02.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When we enable/disable a node it should be reflected in the LlapDaemon
> metrics, so the administrator can act upon the disabled nodes. They can
> manually check the status and either reenable them by restart, or fix the
> existing issues causing the problems
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
