[
https://issues.apache.org/jira/browse/HIVE-21637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879774#comment-16879774
]
Hive QA commented on HIVE-21637:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
47s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
20s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
23s{color} | {color:blue} storage-api in master has 48 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
30s{color} | {color:blue} standalone-metastore/metastore-common in master has
31 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
12s{color} | {color:blue} standalone-metastore/metastore-server in master has
179 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
5s{color} | {color:blue} ql in master has 2252 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
30s{color} | {color:blue} beeline in master has 44 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
30s{color} | {color:blue} hcatalog/server-extensions in master has 3 extant
Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
25s{color} | {color:blue}
standalone-metastore/metastore-tools/metastore-benchmarks in master has 3
extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
40s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
50s{color} | {color:blue} itests/util in master has 44 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
3s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} storage-api: The patch generated 1 new + 5 unchanged -
0 fixed = 6 total (was 5) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
15s{color} | {color:red} standalone-metastore/metastore-common: The patch
generated 9 new + 498 unchanged - 2 fixed = 507 total (was 500) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
40s{color} | {color:red} standalone-metastore/metastore-server: The patch
generated 164 new + 2193 unchanged - 65 fixed = 2357 total (was 2258) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
50s{color} | {color:red} ql: The patch generated 27 new + 1020 unchanged - 10
fixed = 1047 total (was 1030) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} standalone-metastore/metastore-tools/tools-common: The
patch generated 5 new + 31 unchanged - 0 fixed = 36 total (was 31) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
12s{color} | {color:red} itests/hcatalog-unit: The patch generated 2 new + 24
unchanged - 3 fixed = 26 total (was 27) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
18s{color} | {color:red} itests/hive-unit: The patch generated 3 new + 163
unchanged - 1 fixed = 166 total (was 164) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
14s{color} | {color:red} itests/util: The patch generated 2 new + 18 unchanged
- 0 fixed = 20 total (was 18) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
16s{color} | {color:red} standalone-metastore/metastore-server generated 9 new
+ 174 unchanged - 5 fixed = 183 total (was 179) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
19s{color} | {color:red} standalone-metastore_metastore-server generated 1 new
+ 26 unchanged - 0 fixed = 27 total (was 26) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 68m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
| | Redundant nullcheck of tbl, which is known to be non-null in
org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.drop_table_core(RawStore,
String, String, String, boolean, EnvironmentContext, String) Redundant null
check at HiveMetaStore.java:is known to be non-null in
org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.drop_table_core(RawStore,
String, String, String, boolean, EnvironmentContext, String) Redundant null
check at HiveMetaStore.java:[line 2639] |
| | Redundant nullcheck of partitionSpecs which is known to be null in
org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_part_specs_by_filter(String,
String, String, int, String) Redundant null check at HiveMetaStore.java:is
known to be null in
org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_part_specs_by_filter(String,
String, String, int, String) Redundant null check at HiveMetaStore.java:[line
6485] |
| | Redundant nullcheck of partitionSpecs which is known to be null in
org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_partitions_pspec(String,
String, int, String) Redundant null check at HiveMetaStore.java:is known to
be null in
org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_partitions_pspec(String,
String, int, String) Redundant null check at HiveMetaStore.java:[line 5009] |
| | Dead store to catNames in
org.apache.hadoop.hive.metastore.cache.CachedStore.prewarm(RawStore,
Configuration) At
CachedStore.java:org.apache.hadoop.hive.metastore.cache.CachedStore.prewarm(RawStore,
Configuration) At CachedStore.java:[line 511] |
| | Load of known null value in
org.apache.hadoop.hive.metastore.cache.CachedStore.get_aggr_stats_for(String,
String, String, List, List, String) At CachedStore.java:in
org.apache.hadoop.hive.metastore.cache.CachedStore.get_aggr_stats_for(String,
String, String, List, List, String) At CachedStore.java:[line 1777] |
| | Write to static field
org.apache.hadoop.hive.metastore.cache.CachedStore.cacheHit from instance
method
org.apache.hadoop.hive.metastore.cache.CachedStore.setConf(Configuration) At
CachedStore.java:from instance method
org.apache.hadoop.hive.metastore.cache.CachedStore.setConf(Configuration) At
CachedStore.java:[line 149] |
| | Write to static field
org.apache.hadoop.hive.metastore.cache.CachedStore.cacheMiss from instance
method
org.apache.hadoop.hive.metastore.cache.CachedStore.setConf(Configuration) At
CachedStore.java:from instance method
org.apache.hadoop.hive.metastore.cache.CachedStore.setConf(Configuration) At
CachedStore.java:[line 150] |
| | Write to static field
org.apache.hadoop.hive.metastore.cache.CachedStore.counterInited from instance
method
org.apache.hadoop.hive.metastore.cache.CachedStore.setConf(Configuration) At
CachedStore.java:from instance method
org.apache.hadoop.hive.metastore.cache.CachedStore.setConf(Configuration) At
CachedStore.java:[line 151] |
| | Redundant nullcheck of tableColStats, which is known to be non-null in
org.apache.hadoop.hive.metastore.cache.SharedCache.populateTableInCache(Table,
ColumnStatistics, List, List, AggrStats, AggrStats, ValidWriteIdList)
Redundant null check at SharedCache.java:is known to be non-null in
org.apache.hadoop.hive.metastore.cache.SharedCache.populateTableInCache(Table,
ColumnStatistics, List, List, AggrStats, AggrStats, ValidWriteIdList)
Redundant null check at SharedCache.java:[line 1079] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc xml compile findbugs
checkstyle |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17891/dev-support/hive-personality.sh
|
| git revision | master / 6e4c500 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17891/yetus/diff-checkstyle-storage-api.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17891/yetus/diff-checkstyle-standalone-metastore_metastore-common.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17891/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17891/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17891/yetus/diff-checkstyle-standalone-metastore_metastore-tools_tools-common.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17891/yetus/diff-checkstyle-itests_hcatalog-unit.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17891/yetus/diff-checkstyle-itests_hive-unit.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17891/yetus/diff-checkstyle-itests_util.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17891/yetus/new-findbugs-standalone-metastore_metastore-server.html
|
| javadoc |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17891/yetus/diff-javadoc-javadoc-standalone-metastore_metastore-server.txt
|
| modules | C: storage-api standalone-metastore/metastore-common
standalone-metastore/metastore-server ql hcatalog/server-extensions beeline
standalone-metastore/metastore-tools/tools-common
standalone-metastore/metastore-tools/metastore-benchmarks itests/hcatalog-unit
itests/hive-unit itests/util U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17891/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Synchronized metastore cache
> ----------------------------
>
> Key: HIVE-21637
> URL: https://issues.apache.org/jira/browse/HIVE-21637
> Project: Hive
> Issue Type: New Feature
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Priority: Major
> Attachments: HIVE-21637-1.patch, HIVE-21637.10.patch,
> HIVE-21637.11.patch, HIVE-21637.12.patch, HIVE-21637.13.patch,
> HIVE-21637.14.patch, HIVE-21637.15.patch, HIVE-21637.16.patch,
> HIVE-21637.17.patch, HIVE-21637.2.patch, HIVE-21637.3.patch,
> HIVE-21637.4.patch, HIVE-21637.5.patch, HIVE-21637.6.patch,
> HIVE-21637.7.patch, HIVE-21637.8.patch, HIVE-21637.9.patch
>
>
> Currently, HMS has a cache implemented by CachedStore. The cache is
> asynchronized and in HMS HA setting, we can only get eventual consistency. In
> this Jira, we try to make it synchronized.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
