[
https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884959#comment-16884959
]
Hive QA commented on HIVE-21980:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
1s{color} | {color:blue} ql in master has 2253 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
41s{color} | {color:red} ql: The patch generated 3 new + 4 unchanged - 2 fixed
= 7 total (was 6) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
18s{color} | {color:red} ql generated 9 new + 2240 unchanged - 13 fixed = 2249
total (was 2253) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 1s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Dead store to LPAREN29 in
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource()
At
HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource()
At HiveParser_FromClauseParser.java:[line 1856] |
| | Dead store to RPAREN31 in
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource()
At
HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource()
At HiveParser_FromClauseParser.java:[line 1863] |
| | Dead store to LPAREN47 in
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.uniqueJoinExpr()
At
HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.uniqueJoinExpr()
At HiveParser_FromClauseParser.java:[line 2279] |
| | Dead store to RPAREN49 in
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.uniqueJoinExpr()
At
HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.uniqueJoinExpr()
At HiveParser_FromClauseParser.java:[line 2286] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA14
be a _static_ inner class? At HiveParser_FromClauseParser.java:inner class?
At HiveParser_FromClauseParser.java:[lines 8657-8670] |
| | Dead store to LA21_31 in
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA21.specialStateTransition(int,
IntStream) At
HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA21.specialStateTransition(int,
IntStream) At HiveParser_FromClauseParser.java:[line 8867] |
| | Dead store to LA24_31 in
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA24.specialStateTransition(int,
IntStream) At
HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA24.specialStateTransition(int,
IntStream) At HiveParser_FromClauseParser.java:[line 9080] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA39
be a _static_ inner class? At HiveParser_FromClauseParser.java:inner class?
At HiveParser_FromClauseParser.java:[lines 9368-9381] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA43
be a _static_ inner class? At HiveParser_FromClauseParser.java:inner class?
At HiveParser_FromClauseParser.java:[lines 9669-9682] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18028/dev-support/hive-personality.sh
|
| git revision | master / a669ca4 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18028/yetus/diff-checkstyle-ql.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18028/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18028/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Parsing time can be high in case of deeply nested subqueries
> ------------------------------------------------------------
>
> Key: HIVE-21980
> URL: https://issues.apache.org/jira/browse/HIVE-21980
> Project: Hive
> Issue Type: Improvement
> Components: Parser
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Attachments: HIVE-21980.01.patch, HIVE-21980.01.patch,
> HIVE-21980.02.patch, HIVE-21980.03.patch
>
>
> for queries which are recursively doing:
> {code}
> SELECT ...
> FROM (SELECT ...
> FROM ( [...]
> ) JOIN
> (SELECT ...
> FROM ( [...] )
> JOIN ( [...]
> )
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
