[
https://issues.apache.org/jira/browse/HIVE-21960?focusedWorklogId=286480&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286480
]
ASF GitHub Bot logged work on HIVE-21960:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/19 06:56
Start Date: 01/Aug/19 06:56
Worklog Time Spent: 10m
Work Description: ashutosh-bapat commented on pull request #735:
HIVE-21960 : Avoid running stats updater and partition management task on a
replicated table.
URL: https://github.com/apache/hive/pull/735#discussion_r309547312
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionManagementTask.java
##########
@@ -80,6 +82,16 @@ public Configuration getConf() {
return conf;
}
+ private static boolean partitionDiscoveryEnabled(Map<String, String> params)
{
+ return params != null &&
params.containsKey(DISCOVER_PARTITIONS_TBLPROPERTY) &&
+
params.get(DISCOVER_PARTITIONS_TBLPROPERTY).equalsIgnoreCase("true");
+ }
+
+ private static boolean tblBeingReplicatedInto(Map<String, String> params) {
+ return params != null &&
params.containsKey(ReplConst.REPL_TARGET_TABLE_PROPERTY) &&
+ !params.get(ReplConst.REPL_TARGET_TABLE_PROPERTY).trim().isEmpty();
Review comment:
params may contain REPL_TARGET_TABLE_PROPERTY but it may be an empty string
''. That will not happen through the code since we always add non-empty string.
But this is an extra check to cover that possibility in case somebody adds an
empty string there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 286480)
Time Spent: 2h 20m (was: 2h 10m)
> HMS tasks on replica
> --------------------
>
> Key: HIVE-21960
> URL: https://issues.apache.org/jira/browse/HIVE-21960
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2, repl
> Affects Versions: 4.0.0
> Reporter: Ashutosh Bapat
> Assignee: Ashutosh Bapat
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21960.01.patch, HIVE-21960.02.patch,
> HIVE-21960.03.patch, HIVE-21960.04.patch, HIVE-21960.05.patch,
> HIVE-21960.06.patch, Replication and House keeping tasks.pdf
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> An HMS performs a number of housekeeping tasks. Assess whether
> # They are required to be performed in the replicated data
> # Performing those on replicated data causes any issues and how to fix those.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
